Suppress CredScan finding for testcert.key.pem test certificate - #2074
Merged
Badrish Chandramouli (badrishc) merged 1 commit intoAug 18, 2026
Merged
Conversation
The PEM certificate support added in #1937 introduced test/testcerts/testcert.key.pem, a PEM-encoded private key for the self-signed certificate used by TLS unit tests. CredScan flags its private key, breaking the compliance build. Add it to the CredScan exclusion list alongside the other test certificate/key files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ebda3282-4ac2-49f9-820a-d658443b15ae
Copilot started reviewing on behalf of
Badrish Chandramouli (badrishc)
August 18, 2026 20:28
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the PEM test private key to CredScan suppressions so compliance builds accept the TLS test fixture.
Changes:
- Excludes
testcert.key.pemwith a test-only justification.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevin-montrose
approved these changes
Aug 18, 2026
Badrish Chandramouli (badrishc)
merged commit Aug 18, 2026
eb956b5
into
main
167 of 168 checks passed
Badrish Chandramouli (badrishc)
deleted the
badrishc/credscan-suppress-testcert-key-pem
branch
August 18, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PEM certificate support added in #1937 introduced test/testcerts/testcert.key.pem, a PEM-encoded private key for the self-signed certificate used by TLS unit tests. CredScan flags its private key, breaking the compliance build. Add it to the CredScan exclusion list alongside the other test certificate/key files.