Skip Interlocked.Exchange and FlushConfig when no update detected - #905
Merged
Vasileios Zois (vazois) merged 5 commits intoJan 9, 2025
Merged
Conversation
Vasileios Zois (vazois)
force-pushed
the
vazois/config-update
branch
3 times, most recently
from
January 9, 2025 02:37
894c344 to
49c0edd
Compare
Badrish Chandramouli (badrishc)
approved these changes
Jan 9, 2025
Badrish Chandramouli (badrishc)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, please update version for a new release as well.
Vasileios Zois (vazois)
marked this pull request as draft
January 9, 2025 19:15
Vasileios Zois (vazois)
force-pushed
the
vazois/config-update
branch
from
January 9, 2025 19:49
e45088d to
952bc14
Compare
Vasileios Zois (vazois)
marked this pull request as ready for review
January 9, 2025 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that caused message flooding across the cluster. This happened because the config object kept being updated even when the received config did not change the local config during merge.
The check for an updated config is happening implicitly by comparing the new and current config objects
garnet/libs/cluster/Server/Gossip.cs
Lines 116 to 123 in af9cf0e
This meant that the call to currentCopy.Merge should return the same object if no update has happened. This occurs correctly when merging the worker info
garnet/libs/cluster/Server/ClusterConfig.cs
Line 917 in af9cf0e
However, an equivalent check was not there when the object was updated during the merging of the slotMap information.
The PR adds this check to fix the issue of message flooding when the cluster configuration is stable
Fixes #900