Uses the new expression in RespCommandsInfo.cs - #99
Closed
Tyler Standridge (TStand90) wants to merge 3 commits into
Closed
Uses the new expression in RespCommandsInfo.cs#99Tyler Standridge (TStand90) wants to merge 3 commits into
new expression in RespCommandsInfo.cs#99Tyler Standridge (TStand90) wants to merge 3 commits into
Conversation
Tyler Standridge (TStand90)
force-pushed
the
lint/RespCommandInfo-targeted-type-new
branch
from
March 22, 2024 19:31
91eccd9 to
a26730f
Compare
This uses the targeted-type `new` expressions in RespCommandsInfo cs, which follows the advice laid out in [Style rule IDE0090](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0090)
Tyler Standridge (TStand90)
force-pushed
the
lint/RespCommandInfo-targeted-type-new
branch
from
March 22, 2024 21:06
a26730f to
c1f90ef
Compare
Contributor
|
Thank you for your contribution to Garnet! We will address issues such as this in a wider code-style "overhaul" using .editorconfig rules to enforce, so closing this for now.... Thanks again! |
Tyler Standridge (TStand90)
deleted the
lint/RespCommandInfo-targeted-type-new
branch
March 27, 2024 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the targeted-type
newexpressions in RespCommandsInfo cs, which follows the advice laid out in Style rule IDE0090