AlertManager - fix deployment template issue - #106
Merged
Conversation
Yuting Jiang (yukirora)
temporarily deployed
to
auto-test
October 24, 2025 07:56 — with 
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a deployment template parsing error that occurs when optional configuration sections (lucia, abnormal-detector) are not present in the cluster configuration. The changes add conditional checks to prevent template rendering failures when these optional settings are missing.
Key changes:
- Added conditional guards around LUCIA-related environment variables
- Added conditional guard around abnormal-detector configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Yuting Jiang (yukirora)
temporarily deployed
to
auto-test
October 24, 2025 07:57 — with
GitHub Actions
Inactive
Yuting Jiang (yukirora)
requested review from
Yifan Xiong (abuccts) and
Rui Gao (hippogr)
October 27, 2025 04:08
26 tasks
Rui Gao (hippogr)
approved these changes
Nov 5, 2025
zhogu
approved these changes
Nov 5, 2025
Yifan Xiong (abuccts)
approved these changes
Nov 6, 2025
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major Revision