Skip to content

fix the error when lucia URL is not available - #184

Merged
Rui Gao (hippogr) merged 5 commits into
devfrom
ruigao/fix-cluster-crash
Jun 15, 2026
Merged

fix the error when lucia URL is not available#184
Rui Gao (hippogr) merged 5 commits into
devfrom
ruigao/fix-cluster-crash

Conversation

@hippogr

Copy link
Copy Markdown
Contributor

fix the error when lucia URL is not available

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the alert-manager cluster utilization reporting script to be more resilient when the Lucia-based report source fails (e.g., missing/invalid Lucia URL) by adding error handling around report collection and alert sending.

Changes:

  • Wrap Lucia report collection in a try/except to avoid uncaught exceptions during report retrieval.
  • Add an explicit else branch to handle unknown REPORT_SOURCE values.
  • Wrap send_alert(...) in a try/except to log failures during alert delivery.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/alert-manager/src/cluster-utilization/send_alert.py
Comment thread src/alert-manager/src/cluster-utilization/send_alert.py Outdated
Comment thread src/alert-manager/src/cluster-utilization/send_alert.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
…mpty services

- Change -i argument from comma-separated to space-separated to match
  argparse nargs='+' expectations
- Skip build/push when changed_services is empty after removing alert-manager
- Add continue in build-all to avoid rebuilding alert-manager without image filter

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Two issues caused S360 alerts after CI deployment:
1. docker build --no-cache does not pull fresh base images, so the
   self-hosted runner reuses its cached (vulnerable) azurelinux image.
   Add --pull to force fetching the latest base image on every build.
2. ACR push step lacked -i filter for alert-manager, potentially pushing
   old unbuilt images from the runner's Docker cache. Align ACR push
   with the GHCR push logic.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
@hippogr
Rui Gao (hippogr) merged commit cad9352 into dev Jun 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants