Fix copy error when building images of job-exporter with docker 28.2+ - #97
Merged
Conversation
zhogu
marked this pull request as ready for review
October 15, 2025 07:05
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a file copying issue in the Docker build process for job-exporter when using Docker version 28.2+. The change ensures compatibility with newer Docker versions by making the destination path explicit.
- Updated COPY command destination path to use explicit
./syntax
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Rui Gao (hippogr)
approved these changes
Oct 16, 2025
Yuting Jiang (yukirora)
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the
job-exporter.common.dockerfileto ensure consistency in file copying commands.The previous error is due to a stricter rule introduced in Docker 28.2 (BuildKit) about how COPY handles wildcards and multiple sources.
COPYcommand formoneo-*-exporter_entrypoint.shto explicitly use the./destination, aligning it with Docker best practices.