Allow non-System32 DLL Loads for Sanitizer Builds #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4886 +/- ##
==========================================
- Coverage 87.27% 86.88% -0.40%
==========================================
Files 56 56
Lines 17630 17630
==========================================
- Hits 15386 15317 -69
- Misses 2244 2313 +69 ☔ View full report in Codecov by Sentry. |
mtfriesen
approved these changes
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When compiled for sanitizer builds, ASAN loads from a local directory. So, we must relax the production requirement to load from only system32.
Testing
Locally and CI/CD
Documentation
N/A