Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for Dumps #4887

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Wait for Dumps #4887

merged 3 commits into from
Mar 3, 2025

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Mar 3, 2025

Description

Often we're not actually seeing a dump file when a stress test crashes. Try adding a wait in there for up to 30 seconds.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner March 3, 2025 16:15
@nibanks nibanks added Area: Testing Related to test coverage Area: Automation labels Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (257a038) to head (e298d24).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4887      +/-   ##
==========================================
- Coverage   87.27%   86.84%   -0.44%     
==========================================
  Files          56       56              
  Lines       17630    17630              
==========================================
- Hits        15386    15310      -76     
- Misses       2244     2320      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 1a1d980 into main Mar 3, 2025
387 of 390 checks passed
@nibanks nibanks deleted the wait-for-dumps branch March 3, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Automation Area: Testing Related to test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants