SetupDataPkg: Conf app support multiple input keys#588
Merged
apop5 merged 1 commit intomicrosoft:mainfrom Apr 3, 2026
Merged
Conversation
The boot option menu supports up to 10 boot options, but the key input only support reading a single key press. This resulted in only a single keypress of 0-9 resulting in booting. attempting to press 1 + 0 would result in booting option 1. Modify the keypress code to read until an enter key is pressed. i.e. 1 + <enter> will boot option 1, 1 + 0 + <enter> will result in boot option 10 booting. Updated unit test to test multi key press.
1 task
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 28.83% 28.99% +0.15%
==========================================
Files 23 23
Lines 7269 7291 +22
Branches 624 631 +7
==========================================
+ Hits 2096 2114 +18
- Misses 5167 5171 +4
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
os-d
approved these changes
Apr 2, 2026
kuqin12
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The boot option menu supports up to 10 boot options, but the key input only support reading a single key press. This resulted in only a single keypress of 0-9 resulting in booting. attempting to press 1 + 0 would result in booting option 1.
Modify the keypress code to read until an enter key is pressed. i.e. 1 + will boot option 1, 1 + 0 + will result in boot option 10 booting.
Updated unit test to test multi key press.
This is a change in functionality in that now an is required to get boot to select an option.
While this is not a breaking change, it will be a change in behavior for the user.
How This Was Tested
Boot Q35, with modified code which printed keypresed.
pressing 1 + 0 + resulted in reading 10.
Integration Instructions
No integration necessary.