Skip to content

Commit

Permalink
Add remaining build options and make minor changes in documentation (#39
Browse files Browse the repository at this point in the history
)

* Minor changes in documentation

* Synchronous, not sync

* Add remaining build options after mkldnn fix
  • Loading branch information
pranavsharma authored Nov 28, 2018
1 parent 3b11409 commit 3f4589c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# turn off readability-braces-around-statements to allow single line statement like 'if (x == y) doSomething();'
Checks: '-*,cppcoreguidelines-*,google-*,readability-*,modernize-*,-readability-braces-around-statements,-google-runtime-references,-cppcoreguidelines-pro-type-reinterpret-cast'
WarningsAsErrors: ''
HeaderFilterRegex: '.*lotus\/core\/.*'
HeaderFilterRegex: '.*onnxruntime\/core\/.*'
AnalyzeTemporaryDtors: false
FormatStyle: none
CheckOptions:
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ gen
.vs
TestResults/
.idea/
lotus.egg-info
onnxruntime.egg-info
nuget_root/
.packages/
.vscode/
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ git commit -m "my changes"
git push origin HEAD
```
To request merge into master send a pull request from the web ui
https://github.com/Microsoft/onnxruntime
https://github.com/Microsoft/onnxruntime and add 'Microsoft/onnxruntime' as a reviewer.

New code *must* be accompanied by unit tests.

# Build
Expand Down
3 changes: 1 addition & 2 deletions docs/HighLevelDesign.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ provider).

Conceptually, each partition is reduced to a single fused operator. It is
created by invoking the execution provider's Compile() method and wrap it as a
custom operator. We support both sync and async modes of execution for custom
operators. We also support both strict and non-strict invocations. An execution
custom operator. Currently we support only synchronous mode of execution. An execution
provider exposes its memory allocator, which is used to allocate the input
tensors for the execution provider. The rewriting and partitioning transform the
initial model graph into a new graph composed with operators assigned to either
Expand Down
2 changes: 1 addition & 1 deletion tools/ci_build/github/azure-pipelines/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- task: BatchScript@1
inputs:
filename: build.bat
arguments: ' --enable_onnx_tests --use_mkldnn --enable_pybind'
arguments: ' --enable_pybind --use_mkldnn --use_mklml --build_shared_lib --enable_onnx_tests'
workingFolder: "$(Build.SourcesDirectory)"

- task: CmdLine@1
Expand Down

0 comments on commit 3f4589c

Please sign in to comment.