Remove training packages from onnxruntime-ios-packaging-pipeline #25451
+25
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and streamline configuration for Full variant
|
It's failing: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tools/ci_build/github/apple/objectivec/assemble_objc_pod_package.py
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jul 22, 2025
tools/ci_build/github/apple/objectivec/assemble_objc_pod_package.py
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jul 22, 2025
tools/ci_build/github/azure-pipelines/templates/stages/mac-ios-packaging-build-stage.yml
Outdated
Show resolved
Hide resolved
edgchen1
previously approved these changes
Jul 22, 2025
…-packaging-build-stage.yml Co-authored-by: Edward Chen <[email protected]>
edgchen1
approved these changes
Jul 30, 2025
|
|
||
|
|
||
| def get_pod_config_file(package_variant: PackageVariant): | ||
| def get_pod_config_file(): | ||
| """ | ||
| Gets the pod configuration file path for the given package variant. |
There was a problem hiding this comment.
Suggested change
| Gets the pod configuration file path for the given package variant. | |
| Gets the pod configuration file path. |
| copy_repo_relative_to_dir, | ||
| gen_file_from_template, | ||
| get_podspec_values, | ||
| load_json_config, | ||
| ) | ||
|
|
||
|
|
||
| def get_pod_config_file(package_variant: PackageVariant): | ||
| def get_pod_config_file(): | ||
| """ | ||
| Gets the pod configuration file path for the given package variant. |
There was a problem hiding this comment.
Suggested change
| Gets the pod configuration file path for the given package variant. | |
| Gets the pod configuration file path. |
| @@ -84,35 +83,25 @@ | |||
| } | |||
|
|
|||
|
|
|||
| def get_pod_files(package_variant: PackageVariant): | |||
| def get_pod_files(): | |||
| """ | |||
| Gets the source and header files for the given package variant. | |||
There was a problem hiding this comment.
Suggested change
| Gets the source and header files for the given package variant. | |
| Gets the source and header files. |
|
Hope we can get it included in this upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove support for multiple package variants (
FullandTraining) in the Apple packaging pipeline, consolidating the codebase to only support theFullvariant. The changes simplify the code by eliminating thePackageVariantenum, related logic, and configuration files for theTrainingvariant.