[EP ABI] Signatures for compatibility info methods #25454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrastogi
force-pushed
the
adrastogi/compat-string-interface
branch
from
853e43c to
ed770dd
Compare
|
LGTM |
|
Looks good. Thanks |
adrianlizarraga
approved these changes
Jul 22, 2025
jywu-msft
approved these changes
Jul 22, 2025
skottmckay
reviewed
Jul 22, 2025
| * | ||
| * \since Version 1.23. | ||
| */ | ||
| OrtStatus*(ORT_API_CALL* ValidateCompiledModelCompatibilityInfo)(_In_ OrtEpFactory* this_ptr, |
There was a problem hiding this comment.
This should use ORT_API2_STATUS so we get consistent usage of noexcept.
skottmckay
reviewed
Jul 22, 2025
Comment on lines
+699
to
+700
| const char*(ORT_API_CALL* GetCompiledModelCompatibilityInfo)(_In_ OrtEp* this_ptr, | ||
| _In_ const OrtGraph* graph); |
There was a problem hiding this comment.
This should use ORT_API_T so we get consistent usage of noexcept.
skottmckay
pushed a commit
that referenced
this pull request
Jul 23, 2025
### Description This change corrects the signatures on the new precompiled model compatibility APIs to use the recommended macros. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> This fix addresses PR feedback from #25454 . --------- Co-authored-by: Aditya Rastogi <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes two new ABI methods to better support precompiled models. We introduce the concept of a compatibility information string, which is a piece of data produced by an EP implementor to describe the stack that may have been used to compile a model. The
GetCompiledModelCompatibilityInfofunction on theOrtEpinterface creates this string.ORT will get the compatibility information string when precompiling a model and will store the output in the model's metadata. When creating sessions against any precompiled models, ORT will use the
ValidateCompiledModelCompatibilityInfofunction to confirm that the model is still EP-compatible. The EP implementor decides how compatibility is defined for their stack and communicates this via the possible states in theOrtCompiledModelCompatibilityenum.The validation API is stored on the
OrtEpFactoryto allow for cases where a model may not be present on the device yet (e.g., perhaps an application is trying to decide on a pre-compiled model to download based on the state of the system).Motivation and Context
The APIs proposed in this PR address two requirements: