Improves aten_chunk conversion #2434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
+ Coverage 69.23% 69.25% +0.02%
==========================================
Files 210 210
Lines 25389 25381 -8
Branches 2546 2546
==========================================
+ Hits 17577 17578 +1
+ Misses 6939 6929 -10
- Partials 873 874 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
titaiwangms
reviewed
Jul 3, 2025
justinchuby
added
the
module: torchlib
justinchuby
reviewed
Jul 21, 2025
| return op.SplitToSequence(self, list_split, axis=dim) | ||
| if chunks == 1: | ||
| return g.op.Identity(self) | ||
| return g.op.Split(self, axis=dim, num_outputs=chunks) |
There was a problem hiding this comment.
Thanks - the change looks good except for the use of g. Could you update usage? We can then merge
justinchuby
reviewed
Jul 21, 2025
justinchuby
reviewed
Jul 22, 2025
| return op.SplitToSequence(self, list_split, axis=dim) | ||
| if chunks == 1: | ||
| return op.Identity(self) | ||
| return op.Split(self, axis=dim, num_outputs=chunks) |
There was a problem hiding this comment.
I will need to fix the graph builder to return the correct number of outputs
justinchuby
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.