Expose times array - #2027
Merged
Jiri Cincura ↹ (cincuranet) merged 3 commits intoMay 2, 2024
Merged
Conversation
Contributor
Author
|
Brian Robbins (@brianrob), this PR is ready. |
Jiri Cincura ↹ (cincuranet)
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In .NET 6, Maoni Stephens (@Maoni0) introduced the
GCGlobalHeapHistory_V4in dotnet/runtime#55888 that expose some timing information for each phase of the GC and I did the parsing of it in #1758. It turns out just parsing it is not enough, we need to expose it as property onTraceGCin order to be consumed, so this PR expose that array.Unfortunately, the compact time can often be wrong because a bug I fixed in dotnet/runtime#100599, practically that means for some traces, the compact time will be wrong (often seen as 0)