fix: hide cmd.exe window when invoking CLI programmatically - #2623
Merged
Conversation
Dmitry Gozman (dgozman)
approved these changes
Jun 26, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After net8.0-preview4 dotnet/runtime#82662 got landed upstream, which adds support for WindowStyle when Shell=false (default). This fixes the customer reported issue for us. It should not regress any behaviour for previous .NET users, so we can always set this flag when the CLI gets invoked.
Note: This does not require us to change any TFM. Only the customers need to use net8-preview4+. (which is LTS in November this year).
Appreciate the work David Cantú (@jozkee) and cc Jakub Jareš (@nohwnd).
Fixes #2462
Relates #2489
Closes dotnet/runtime#68259 (comment) (not needed anymore).