-
Notifications
You must be signed in to change notification settings - Fork 4.8k
chore(ui): ensure isTTY is correct #38044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
agg23
reviewed
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor clarity suggestions
dgozman
approved these changes
Oct 29, 2025
Test results for "MCP"1 failed 2530 passed, 108 skipped Merge workflow run. |
Test results for "tests 1"3 flaky47196 passed, 813 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37867. Ensures reporters can use
process.stdin.isTTYto detect whether they can listen for SIGINT or not. Migrates HTML reporter to use it.Sadly, it's hard to properly test this because we'd need a TTY emulator like
node-ptyto turn onisTTYin the subprocess. Unsure if that's worth it, so I added a comment instead.I'm not expecting behaviour changes from the HTML reporter change, because:
isTTYisundefinedisTTYisTTYwill stay the sameFor 3rd party reporters that already depend on
process.stdin.isTTYtoday, we'll have a behaviour change in UI mode, but I think that's innocent. It's also the whole point of the change.