Skip to content

fix(types): remove stale screencast annotate option - #42239

Merged
Pavel Feldman (pavelfeldman) merged 2 commits into
mainfrom
copilot/fix-type-definition-annotate-option
Aug 13, 2026
Merged

Pavel Feldman (pavelfeldman) merged 2 commits into
mainfrom
copilot/fix-type-definition-annotate-option

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Screencast.start() still exposed the removed annotate option in TypeScript, despite silently ignoring it at runtime.

  • Types: Remove annotate from the source override and generated declarations.
  • Coverage: Verify TypeScript rejects the unsupported option.
// TypeScript error: `annotate` is not supported.
await page.screencast.start({ annotate: { position: 'top-left' } });

Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix TypeScript type for page.screencast.start() by removing annotate option fix(types): remove stale screencast annotate option Aug 13, 2026
@pavelfeldman
Pavel Feldman (pavelfeldman) marked this pull request as ready for review August 13, 2026 17:44
@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 47b5772 into main Aug 13, 2026
42 of 43 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the copilot/fix-type-definition-annotate-option branch August 13, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: page.screencast.start() still declares removed annotate option in TypeScript types (stale type)

4 participants