feat(storage): capture OPFS in storage state by yury-s · Pull Request #42248 · microsoft/playwright

Yury Semikhatsky (yury-s) · 2026-08-13T22:45:07Z

Summary

add opt-in OPFS capture and restoration to storage state
preserve binary files, nested directories, and empty directories across browser and request contexts
handle Firefox worker-based writes and persistent WebKit contexts

github-actions · 2026-08-14T19:32:01Z

Hi, I'm the Playwright bot — I took a first pass at the CI failures here.

🟡 No failure points at this PR, but three timeouts I can't fully clear

The four red tests are all timedOut, none touch the OPFS/storage-state path this PR changes, and they cluster on two specific bots (mcp-macos-latest-chrome, windows-latest-node22) — the signature of slow/overloaded runners, not a code bug. One is a confirmed pre-existing flake; the other three I can't strictly prove either way, so I'm landing on yellow.

Details

Overall: the diff is scoped to OPFS capture in storage state (fetch.ts, browserContext.ts, networkDispatchers.ts, protocol, docs). It doesn't touch MCP CLI or the trace/UI-mode network tab. Every failure is a timeout, and the same tests time out on the same bots across this PR's last few runs (31830009958, 31830010211) as in the latest report — a bot/OS pattern, not a per-feature one.

Pre-existing flake / infra

[firefox] › mcp/cli-json.spec.ts:220 › request and per-part commands return JSON result (mcp-windows-latest-firefox) — pre-existing flake. In the test-results DB it failed 4 of 723 runs across 2 unrelated PRs, passing the rest. The PR doesn't touch the MCP JSON path.

Uncertain (most likely infra, unproven)

[chrome] › mcp/cli-core.spec.ts:248 › click in iframe (mcp-macos-latest-chrome)
[chrome] › mcp/cli-devtools.spec.ts:189 › request with out-of-range index (mcp-macos-latest-chrome)
[playwright-test] › ui-mode-test-network-tab.spec.ts:107 › should filter network requests by url (windows-latest-node22)

All three have 0 failures across 700–1000+ prior runs in the DB, so I can't cite the same test failing off this PR to call it a flake outright. But they can't be reached by the diff — OPFS storage-state capture has nothing to do with clicking an iframe, an out-of-range MCP request index, or filtering the UI-mode network tab — and all three timedOut on the same two bots in earlier runs of this same PR (31830009958, 31830010211). That reads as slow-runner/infra noise. To be sure, a rerun on those bots should clear them; if the identical (test, bot) timeouts persist across reruns, worth a second look at macOS-chrome / Windows agent load.

_{Triaged by the Playwright bot - agent run}

Pavel Feldman (pavelfeldman) · 2026-08-14T23:25:18Z

+});
+
+it('should round-trip OPFS in a persistent WebKit context', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41400' } }, async ({ browserName, launchPersistent, server }) => {
+  it.skip(browserName !== 'webkit');


that's a weird feature, why supporting something that does not work on major browsers?

Agreed. But WebKit doesn't have current plans to support it in ephemeral contexts and adding it would be a non-trivial effort: yury-s/WebKit@main...yury-s:WebKit:opfs-in-memory

Add opt-in OPFS serialization and restoration for browser and request context storage state, including cross-browser handling and round-trip coverage. Fixes: microsoft#41400

github-actions · 2026-09-01T18:27:38Z

🟢 CI is clear — the one failure is a pre-existing flake

Hi, I'm the Playwright bot and I took a first look at the CI failures.

The latest "tests 1" run has a single real failure, ui-mode-test-network-tab.spec.ts:146 › should pretty-print JSON request body on windows-latest-node22. It's a known flake that also fails on unrelated PRs, and this PR only touches OPFS storage-state code — nothing in the UI-mode network tab. Nothing here to act on.

Details

This PR is OPFS storage-state capture: storageScript.ts, browserContext/fetch client + server, dispatchers, protocol specs, and two storage-state tests. It doesn't touch the UI-mode trace viewer or the network-tab JSON pretty-printer.

Pre-existing flake / infra

[playwright-test] › ui-mode-test-network-tab.spec.ts:146 › should pretty-print JSON request body @windows-latest-node22 — flake. Across the test-results DB this test is green 4488 of 4490 runs; the only other failure is on windows-latest-node22 in PR feat(chromium): roll to r1237 #42072 (roll-into-pw-chromium/1237), a Chromium roll with no relation to this change. Same test, same bot, unrelated PR — the PR isn't responsible.

Flaky (rescued on retry, no action needed)

[chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace @frozen-time-library-chromium-linux
[chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup @chromium-ubuntu-22.04-node24

Both passed on retry in this same report and are unrelated to storage state.

_{Triaged by the Playwright bot - agent run}

github-actions · 2026-09-01T19:33:26Z

Test results for "tests 1"

8 flaky

⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:807 › run-server › should upload a folder `@webkit-ubuntu-22.04-node20`

51290 passed, 1249 skipped

Merge workflow run.

github-actions · 2026-09-01T20:15:15Z

Test results for "MCP"

7711 passed, 1229 skipped

Merge workflow run.

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) force-pushed the fix-41400 branch from 41582e5 to 27a9025 Compare August 14, 2026 16:34

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) marked this pull request as ready for review August 14, 2026 17:24

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) requested review from Devin Rousso (dcrousso) and Dmitry Gozman (dgozman) August 14, 2026 19:01

This comment has been minimized.

Sign in to view

Devin Rousso (dcrousso) approved these changes Aug 14, 2026

View reviewed changes

Pavel Feldman (pavelfeldman) reviewed Aug 14, 2026

View reviewed changes

Comment thread docs/src/api/class-apirequest.md Outdated

Pavel Feldman (pavelfeldman) reviewed Aug 14, 2026

View reviewed changes

This was referenced Aug 27, 2026

chore(trace): remove snapshot pointers from action events #42431

Merged

feat(webkit): roll to r2357 #42437

Closed

fix(tracing): allow restarting tracing after a failed stop #42425

Merged

fix(video): embed recording start time in WebM metadata #42478

Closed

Yury Semikhatsky (yury-s) force-pushed the fix-41400 branch 2 times, most recently from 26455a9 to 68da79b Compare September 1, 2026 17:46

This comment has been minimized.

Sign in to view

feat(storage): capture OPFS in storage state

08b86ea

Add opt-in OPFS serialization and restoration for browser and request context storage state, including cross-browser handling and round-trip coverage. Fixes: microsoft#41400

Yury Semikhatsky (yury-s) force-pushed the fix-41400 branch from 68da79b to 08b86ea Compare September 1, 2026 18:22

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) added 2 commits September 1, 2026 11:31

docs(storage): mention WebKit limitation of the opfs option

89945e2

docs(storage): shorten the opfs WebKit note

f2ba7de

This comment has been minimized.

Sign in to view

Pavel Feldman (pavelfeldman) approved these changes Sep 1, 2026

View reviewed changes

Yury Semikhatsky (yury-s) merged commit 902a864 into microsoft:main Sep 1, 2026
44 of 45 checks passed

Yury Semikhatsky (yury-s) deleted the fix-41400 branch September 1, 2026 21:57

This was referenced Sep 1, 2026

fix(mcp): refuse browser_close when the browser context is shared #42495

Merged

chore: bump WebKit version to 26.6 #42514

Merged

Yury Semikhatsky (yury-s) mentioned this pull request Sep 4, 2026

chore(driver): roll to 1.63.0-alpha-1788460676000 microsoft/playwright-java#1972

Merged

Ayaan Gazali (ayaangazali) mentioned this pull request Sep 6, 2026

[Bug]: storageState with opfs: [] cannot be restored in WebKit, and capturing OPFS there fails outright #42579

Closed

Yusuke Iwaki (YusukeIwaki) mentioned this pull request Sep 7, 2026

[Ports]: Backport client side changes for 1.63 YusukeIwaki/playwright-ruby-client#394

Open

12 tasks

Uh oh!

Conversation

Yury Semikhatsky (yury-s) commented Aug 13, 2026

Summary

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Aug 14, 2026

🟡 No failure points at this PR, but three timeouts I can't fully clear

Uh oh!

Uh oh!

Pavel Feldman (pavelfeldman) Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Yury Semikhatsky (yury-s) Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Sep 1, 2026

🟢 CI is clear — the one failure is a pre-existing flake

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Sep 1, 2026

Test results for "tests 1"

Uh oh!

github-actions Bot commented Sep 1, 2026

Test results for "MCP"

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants