Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/playwright-core/src/server/webkit/webview/wvPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1039,6 +1039,8 @@ export class WVPage implements PageDelegate {
// WebKit started dispatching network events for about:blank after https://commits.webkit.org/292206@main.
if (event.request.url.startsWith('about:'))
return;
if (event.request.url.startsWith('blob:'))
return;

// We do not support intercepting redirects.
if (this._page.needsRequestInterception() && !event.redirectResponse)
Expand Down
2 changes: 2 additions & 0 deletions packages/playwright-core/src/server/webkit/wkPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,8 @@ export class WKPage implements PageDelegate {
// WebKit started dispatching network events for about:blank after https://commits.webkit.org/292206@main.
if (event.request.url.startsWith('about:'))
return;
if (event.request.url.startsWith('blob:'))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does a lot more than just preventing routing blob: and drops all network activity for blob:

return;

// We do not support intercepting redirects.
if (this._page.needsRequestInterception() && !event.redirectResponse)
Expand Down
29 changes: 29 additions & 0 deletions tests/page/page-route.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1138,3 +1138,32 @@ it('should be able to intercept every navigation to a page controlled by service
await page.goto(URL);
expect(interceptions).toBe(2);
});

it('should not report blob: urls to route handler', async ({ page, server }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42727' });

const seen: string[] = [];
await page.route('**/*', route => {
seen.push(route.request().url());
return route.continue();
});
await page.goto(server.EMPTY_PAGE);
const reply = await page.evaluate(async () => {
const blob = new Blob(['self.postMessage("ready")'], { type: 'text/javascript' });
const worker = new Worker(URL.createObjectURL(blob));
return await new Promise(resolve => {
worker.onmessage = (e: any) => resolve(e.data);
});
});
expect(reply).toBe('ready');

const fetchReply = await page.evaluate(async () => {
const blob = new Blob(['hello blob'], { type: 'text/plain' });
const blobUrl = URL.createObjectURL(blob);
const res = await fetch(blobUrl);
return await res.text();
});
expect(fetchReply).toBe('hello blob');

expect(seen.filter(url => url.startsWith('blob:'))).toEqual([]);
});
Loading