Skip to content

chore(proxy): drop legacy 'per-context' launch proxy handling - #42892

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:chore-per-context-proxy
Sep 24, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:chore-per-context-proxy

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • per-context launch proxy was a placeholder for an old Chromium workaround (removed in chore: remove Chromium Windows proxy hacks #31724); treat it as no launch proxy at launch time.
  • Remove the per-context string checks in fetch and client certificates, which never matched the normalized http://per-context value.

'per-context' was a placeholder launch proxy required by an old Chromium
workaround. Treat it as no launch proxy at launch time and remove the
string checks in fetch and client certificates, which never matched the
normalized 'http://per-context' value.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:725 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:113 › screencast › should capture static page `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52144 passed, 1241 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5 failed
❌ [chrome] › mcp/cli-webmcp.spec.ts:188 › webmcp-call disambiguates same-name tools in identical same-origin frames @mcp-macos-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:417 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-chrome
❌ [chromium] › mcp/screenshot.spec.ts:468 › browser_take_screenshot (viewport without snapshot) @mcp-windows-latest-chromium
❌ [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox

8700 passed, 1474 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 No failures look caused by this PR

Hi, I'm the Playwright bot and I triaged the failing CI run. All 5 failures are MCP tests that
already fail intermittently on unrelated SHAs, and none of them touch proxy configuration —
the only thing this PR changes.

Details

The diff is confined to launch/context proxy plumbing (browserType.ts normalization,
browser.ts client-cert proxy, fetch.ts proxy agent) plus a new
browsercontext-proxy.spec.ts test. The MCP screencast/annotate/webmcp flows that failed don't
configure a proxy, so there's no path from this change to them. The PR's own new proxy tests
passed.

Pre-existing flake / infra

All five are on the Windows/macOS MCP bots, which is where the screencast timing tests are
flakiest. I'm a first pass, not the final word — but the history here is unambiguous enough
that a rerun should come back green.

Triaged by the Playwright bot - agent run

@yury-s
Yury Semikhatsky (yury-s) merged commit 85b9473 into microsoft:main Sep 24, 2026
41 of 45 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the chore-per-context-proxy branch September 24, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants