Adding fix for Manual set value clearTextOnSubmit-style behavior not working on Fabric #15277

protikbiswas100 · 2025-10-23T05:25:36Z

Description

TextInput regression between Paper and Fabric: Manual set value clearTextOnSubmit-style behavior not working

Type of Change

Bug fix (non-breaking change which fixes an issue)

Why

The issue is that JavaScript receives onSubmitEditing with eventCount N, but when it immediately calls setValue(''), native has already moved to N+1, so the JS command gets rejected. This causes mismatch between JS and Native side

Resolves [https://github.com//issues/15168]

What

The issue is that JavaScript receives onSubmitEditing with eventCount N, but when it immediately calls setValue('') native has already moved to N+1, so the JS command gets rejected. To fix the issue the solution taken is don't increment the event count until AFTER the JavaScript has had a chance to respond to the submit event.

Screenshots

Before

15168-before.mp4

After

15168-after.mp4

Testing

yarn build passed successfully, added a sample textInput field in RNTester-Fabric app to repro the issue.

Ran E2ETestAppFabric Unit Test

Changelog

Should this change be included in the release notes: yes

Added synchroinization logic betwwen JS and native layer onClearSubmit is not working

Microsoft Reviewers: Open in CodeFlow

protikbiswas100 · 2025-10-23T05:25:50Z

/azp run

azure-pipelines · 2025-10-23T05:26:03Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-10-23T05:26:47Z

/azp run

azure-pipelines · 2025-10-23T05:27:05Z

Azure Pipelines successfully started running 2 pipeline(s).

Copilot

Pull Request Overview

This PR fixes a regression in TextInput behavior between Paper and Fabric architectures where manual value clearing on submit (clearTextOnSubmit-style behavior) was not working correctly. The issue occurred when JavaScript immediately updated the text value during onSubmitEditing, causing synchronization problems between native and JS state.

Key Changes:

Modified event count validation to accept immediate JS updates by changing the condition from eventCount >= m_nativeEventCount to eventCount >= m_nativeEventCount - 1
Added state synchronization when clearing text to ensure React state stays consistent with native TextInput state

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp`	Modified event count check and added state update logic when clearing text on submit
`change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f6676.json`	Added change file for versioning

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f6676.json

…76.json Co-authored-by: Copilot <[email protected]>

anupriya13 · 2025-10-23T06:26:55Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

protikbiswas100 · 2025-10-23T06:28:43Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

I pressed back slash key by mistake after pressing enter from my keyboard

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

protikbiswas100 · 2025-10-23T06:29:55Z

/azp run

azure-pipelines · 2025-10-23T06:30:09Z

Azure Pipelines successfully started running 2 pipeline(s).

anupriya13 · 2025-10-23T06:30:16Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

I pressed back slash key by mistake after pressing enter from my keyboard

Okay can you please re-record and attach correct before and after videos?

anupriya13 · 2025-10-23T06:31:42Z

Description Summary missing in the end.
"Add a brief summary of the change to use in the release notes for the next release."

anupriya13 · 2025-10-23T06:33:13Z

E2ETestAppFabric Unit Test verification?

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

protikbiswas100 · 2025-10-27T06:38:45Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

I pressed back slash key by mistake after pressing enter from my keyboard

Okay can you please re-record and attach correct before and after videos?

reuploaded before and after videos

protikbiswas100 · 2025-10-27T06:43:21Z

E2ETestAppFabric Unit Test verification

Added in next commit

protikbiswas100 · 2025-10-27T06:44:20Z

Description Summary missing in the end. "Add a brief summary of the change to use in the release notes for the next release."

It's already there in description

…react-native-windows into textInput-15168

protikbiswas100 · 2025-10-30T08:30:23Z

/azp run

azure-pipelines · 2025-10-30T08:30:37Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-03T07:04:08Z

/azp run

azure-pipelines · 2025-11-03T07:04:22Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-03T07:05:44Z

E2ETestAppFabric Unit Test verification

Added in next commit

Just curios @protikbiswas100. Why not reply directly to the comment where the question was asked? I mean it'd be easier to reply and follow. What's the advantage of copying the comment to a blockquote and then replying. I find it hard to follow but if there're any merits in this I'd be happy to learn.

I cannot reply to the comments in the same thread, unless it comes from the review, the conversations that generate with comments I can only quote reply them

protikbiswas100 · 2025-11-03T07:06:05Z

Description Summary missing in the end. "Add a brief summary of the change to use in the release notes for the next release."

It's already there in description

I think it's needed for a tool to parse and post it as part of the release notes. The detailed PR description ≠ one bullet point of this change in release notes.

Added

protikbiswas100 · 2025-11-03T07:08:46Z

Description Summary missing in the end. "Add a brief summary of the change to use in the release notes for the next release."

Added it, also we should not add this line "Add a brief summary of the change to use in the release notes for the next release." if it is Yes, spoke with @sundaramramaswamy regarding this, you can look at the PRs from Redmond team about how a chnagelog file should be for yes #15013

protikbiswas100 · 2025-11-03T08:15:10Z

/azp run

azure-pipelines · 2025-11-03T08:15:23Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-03T08:16:09Z

/azp run

azure-pipelines · 2025-11-03T08:16:24Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-03T08:57:00Z

What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.

Please drop this line from the description. (1) is template string; I see it there despite commenting on this on a previous PR. Please have the discipline to remove template strings that are noise from the PR description.

TextInput regression between Paper and Fabric: Manual set value clearTextOnSubmit-style behavior not working

Both the first line of description and Why sections have this same line. Is the duplication needed? This doesn't convey why this regression happened or how the PR fixes it.

Modified to if (eventCount >= m_nativeEventCount - 1) to allow immediate JS side changes.

Code diff already tells me this, but this line still doesn't convey what the change does. Please briefly write the why and then the how in the description.

I changed the why and what now they are different

protikbiswas100 · 2025-11-03T09:15:23Z

/azp run

azure-pipelines · 2025-11-03T09:15:38Z

Azure Pipelines successfully started running 2 pipeline(s).

acoates-ms · 2025-11-03T18:01:06Z

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

+      onSubmitEditingArgs.eventCount = m_nativeEventCount;
      emitter->onSubmitEditing(onSubmitEditingArgs);
+
+      // Increment after emitting to allow JS to respond with matching count


The JS is run on a separate thread. So if the JS thread is busy at this time, there JS will not have responded by this point.
You can probably reproduce this by pausing the JS thread in the debugger while stepping through this code.

We can keep a buffer of 2 between native and JS event counts, consider below example scenario

Native event N: User types, increment to N+1
Native event N+1: User presses Enter, emit onSubmitEditing with eventCount N+1, increment to N+2
JS thread might be busy here
Native event N+2: Maybe another keystroke, increment to N+3
Now JS thread processes onSubmitEditing and calls setValue('') with eventCount N+1
Native receives setValue('') with eventCount N+1
Check: N+3 - N+1 = 2 <= 2 -> Accepted

Why 2 events tolerance?

1 event behind: Common due to normal async delay
2 events behind: Covers cases where JS thread was busy and one additional user action occurred
More than 2: Likely indicates stale commands that should be rejected for safety

Can you debug how this works in Android? The event count is a synchronization requirements. Accepting events out of order may cause input to be lost.

protikbiswas100 · 2025-11-04T05:15:32Z

/azp run

azure-pipelines · 2025-11-04T05:15:49Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-04T07:10:31Z

/azp run

azure-pipelines · 2025-11-04T07:10:50Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-04T08:27:06Z

/azp run

azure-pipelines · 2025-11-04T08:27:24Z

Azure Pipelines successfully started running 2 pipeline(s).

Protik Biswas added 2 commits October 23, 2025 10:53

adding fix for TextInput

d9ad94e

Change files

0e83625

protikbiswas100 requested a review from a team as a code owner October 23, 2025 05:25

Merge branch 'main' into textInput-15168

8dde8cc

protikbiswas100 mentioned this pull request Oct 23, 2025

TextInput regression between Paper and Fabric: Manual set value clearTextOnSubmit-style behavior not working. #15168

Open

anupriya13 requested a review from Copilot October 23, 2025 06:22

Copilot AI reviewed Oct 23, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp Outdated Show resolved Hide resolved

change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f6676.json Outdated Show resolved Hide resolved

Update change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f66…

da2a4bf

…76.json Co-authored-by: Copilot <[email protected]>

anupriya13 reviewed Oct 23, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp Outdated Show resolved Hide resolved

acoates-ms reviewed Oct 23, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp Outdated Show resolved Hide resolved

Protik Biswas added 4 commits October 27, 2025 12:55

changed logic for native and js side event count

13473ed

Merge branch 'textInput-15168' of https://github.com/protikbiswas100/…

4c8e428

…react-native-windows into textInput-15168

adding formatting changes

8771b9e

adding linting fix

66e141d

fixing linting issue

528c58b

protikbiswas100 force-pushed the textInput-15168 branch from 3d17a2b to 528c58b Compare November 3, 2025 08:14

adding snapshots

8a5fa68

protikbiswas100 force-pushed the textInput-15168 branch from 64e37d7 to 8a5fa68 Compare November 3, 2025 09:14

acoates-ms reviewed Nov 3, 2025

View reviewed changes

chnaging the logic on synchronization between JS and Native side

c4ab9c0

protikbiswas100 force-pushed the textInput-15168 branch from 5ba7e7c to c4ab9c0 Compare November 4, 2025 05:14

fixing linting error

b9ff842

protikbiswas100 force-pushed the textInput-15168 branch from 03e9814 to b9ff842 Compare November 4, 2025 07:10

removing e2e test

2068ef7

protikbiswas100 force-pushed the textInput-15168 branch from 91e1cdd to 2068ef7 Compare November 4, 2025 08:26

Merge branch 'main' into textInput-15168

ab4fa57

Adding fix for Manual set value clearTextOnSubmit-style behavior not working on Fabric #15277

Are you sure you want to change the base?

Adding fix for Manual set value clearTextOnSubmit-style behavior not working on Fabric #15277

Conversation

protikbiswas100 commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Why

What

Screenshots

Testing

Changelog

Microsoft Reviewers: Open in CodeFlow

Microsoft Reviewers: Open in CodeFlow

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

anupriya13 commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

anupriya13 commented Oct 23, 2025

Uh oh!

anupriya13 commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anupriya13 commented Oct 23, 2025

Uh oh!

Uh oh!

protikbiswas100 commented Oct 27, 2025

Uh oh!

protikbiswas100 commented Oct 27, 2025

Uh oh!

protikbiswas100 commented Oct 27, 2025

Uh oh!

protikbiswas100 commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

protikbiswas100 commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

protikbiswas100 commented Nov 3, 2025

Uh oh!

protikbiswas100 commented Nov 3, 2025

Uh oh!

protikbiswas100 commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

protikbiswas100 commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

protikbiswas100 commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

protikbiswas100 commented Nov 3, 2025

Uh oh!

protikbiswas100 commented Oct 23, 2025 •

edited

Loading

anupriya13 commented Oct 23, 2025 •

edited

Loading

anupriya13 commented Oct 23, 2025 •

edited

Loading

protikbiswas100 commented Nov 3, 2025 •

edited

Loading