fix bitwise.and and add tests - #19
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoJun 22, 2023
Merged
Conversation
Anand Krishnamoorthi (anakrish)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution!
To make it complete, we would need tests for the following cases:
- Less number of arguments than expected
- More number of arguments than expected
- Wrong type for argument at each position.
If the tests become large, we could split the files to bitwise/and.yaml, bitwise/lsh.yaml etc.
| pub fn register(m: &mut HashMap<&'static str, builtins::BuiltinFcn>) { | ||
| m.insert("bits.and", and); | ||
| m.insert("bits.and", lsh); | ||
| m.insert("bits.lsh", lsh); |
Collaborator
There was a problem hiding this comment.
Good catch!
| - | | ||
| package test | ||
|
|
||
| x = bits.and(1, "str") |
Collaborator
There was a problem hiding this comment.
Also lock down with a test for and(string, number) as well as with more than two parameters.
Signed-off-by: eric-therond <eric.therond.fr@gmail.com>
eric-therond
force-pushed
the
fixbitwiseand
branch
from
June 21, 2023 17:23
206879b to
f46af00
Compare
Contributor
Author
|
Just added more tests following your suggestion |
Anand Krishnamoorthi (anakrish)
approved these changes
Jun 22, 2023
Anand Krishnamoorthi (anakrish)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.