Skip to content

Python: Update kernel function span#12285

Merged
moonbox3 merged 3 commits into
mainfrom
taochen/update-kernel-function-span
May 28, 2025
Merged

Python: Update kernel function span#12285
moonbox3 merged 3 commits into
mainfrom
taochen/update-kernel-function-span

Conversation

@TaoChenOSU

@TaoChenOSU TaoChenOSU commented May 27, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

Closing #12262

Description

This PR updates tracing support for function execution across both .NET and Python according to the latest OTel GenAI semantic conventions: https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-spans/#execute-tool-span

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this May 27, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner May 27, 2025 20:48
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner May 27, 2025 20:48
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel kernel.core labels May 27, 2025
@github-actions github-actions Bot changed the title Update kernel function span .Net: Update kernel function span May 27, 2025
@github-actions github-actions Bot changed the title .Net: Update kernel function span Python: Update kernel function span May 27, 2025
@markwallace-microsoft

markwallace-microsoft commented May 27, 2025

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
kernel.py2285874%148, 159, 163, 313–314, 316, 398, 404–405, 409–410, 463–467, 469–470, 483–492, 494, 496–497, 499–519, 521–526
filters
   kernel_filters_extension.py790100% 
filters/auto_function_invocation
   auto_function_invocation_context.py110100% 
functions
   kernel_function.py1300100% 
utils/telemetry/model_diagnostics
   function_tracer.py120100% 
   gen_ai_attributes.py310100% 
TOTAL27015457483% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3616 18 💤 0 ❌ 0 🔥 1m 55s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit c0605cc May 28, 2025
31 checks passed
@moonbox3 moonbox3 deleted the taochen/update-kernel-function-span branch May 28, 2025 00:07
@github-project-automation github-project-automation Bot moved this to Sprint: Done in Semantic Kernel May 28, 2025
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Closing microsoft#12262

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
This PR updates tracing support for function execution across both .NET
and Python according to the latest OTel GenAI semantic conventions:
https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-spans/#execute-tool-span

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel.core .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel telemetry

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants