Python: Fix inaccurate split flag in TextChunker to prevent redundant re-splitting#12623
Closed
mohiuddin-khan-shiam wants to merge 3 commits into
Closed
Python: Fix inaccurate split flag in TextChunker to prevent redundant re-splitting#12623mohiuddin-khan-shiam wants to merge 3 commits into
mohiuddin-khan-shiam wants to merge 3 commits into
Conversation
…tting `semantic_kernel.text.text_chunker._split_str` always returned `input_was_split=False` even after splitting, causing higher-level routines to keep searching separators and unnecessarily re-split text. The function now sets `input_was_split=True` as soon as it performs the initial split and continues to propagate deeper recursive flags, improving performance and preserving intended chunk boundaries. Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
…tting `semantic_kernel.text.text_chunker._split_str` always returned `input_was_split=False` even after splitting, causing higher-level routines to keep searching separators and unnecessarily re-split text. The function now sets `input_was_split=True` as soon as it performs the initial split and continues to propagate deeper recursive flags, improving performance and preserving intended chunk boundaries.
markwallace-microsoft
added
the
python
github-actions
Bot
changed the title
Collaborator
|
Hi @mohiuddin-khan-shiam thanks for the contribution. Can you please have a look at the failing unit tests? |
Collaborator
Hello @mohiuddin-khan-shiam, please have a look at the failing unit tests. Thanks. |
Collaborator
|
Please re-open the PR when ready to move forward, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
semantic_kernel.text.text_chunker._split_stralways returnedinput_was_split=Falseeven after splitting, causing higher-level routines to keep searching separators and unnecessarily re-split text.The function now sets
input_was_split=Trueas soon as it performs the initial split and continues to propagate deeper recursive flags, improving performance and preserving intended chunk boundaries.