.Net: AddOpenAIEmbeddingGenerator now respects HttpClient.BaseAddress for endpoint.#12810
Merged
SergeyMenshykh merged 10 commits intoAug 12, 2025
Merged
Conversation
moonbox3
added
.NET
github-actions
Bot
changed the title
jbnidev
reviewed
Jul 28, 2025
rogerbarreto
approved these changes
Jul 31, 2025
jbnidev
approved these changes
Aug 4, 2025
jbnidev
left a comment
jbnidev
left a comment
There was a problem hiding this comment.
This looks good to me. I can see that your change addresses the issue, and it makes sense. This is the first time I have participated in this repo, so I do not have a good feeling for what beyond that I am looking for, but since you have requested my review, and I see somebody else has also reviewed, I will go ahead and approve it.
Contributor
Author
|
Hi @rogerbarreto, @markwallace-microsoft, could you please re-approve and merge? |
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Aug 6, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
… for endpoint. (#12810) ### Description This PR fixes an issue where AddOpenAIEmbeddingGenerator() ignored the BaseAddress of the provided HttpClient, always using the default OpenAI endpoint. Now, if a custom BaseAddress is set on the HttpClient, it is passed as the endpoint parameter, ensuring requests are sent to the correct server. This aligns the behavior with other OpenAI service registrations and enables proxy or custom endpoint scenarios. FIxes #12806 --------- Co-authored-by: Adit Sheth <adsheth@microsoft.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
… for endpoint. (microsoft#12810) ### Description This PR fixes an issue where AddOpenAIEmbeddingGenerator() ignored the BaseAddress of the provided HttpClient, always using the default OpenAI endpoint. Now, if a custom BaseAddress is set on the HttpClient, it is passed as the endpoint parameter, ensuring requests are sent to the correct server. This aligns the behavior with other OpenAI service registrations and enables proxy or custom endpoint scenarios. FIxes microsoft#12806 --------- Co-authored-by: Adit Sheth <adsheth@microsoft.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where AddOpenAIEmbeddingGenerator() ignored the BaseAddress of the provided HttpClient, always using the default OpenAI endpoint. Now, if a custom BaseAddress is set on the HttpClient, it is passed as the endpoint parameter, ensuring requests are sent to the correct server. This aligns the behavior with other OpenAI service registrations and enables proxy or custom endpoint scenarios.
FIxes #12806