Python: .Net: Magentic orchestration to return the last agent message when limits reached#12839
Merged
TaoChenOSU merged 4 commits intoAug 4, 2025
Merged
Conversation
TaoChenOSU
added
.NET
github-actions
Bot
changed the title
crickman
reviewed
Aug 1, 2025
crickman
reviewed
Aug 1, 2025
crickman
left a comment
crickman
left a comment
Contributor
There was a problem hiding this comment.
Might be an opportunity to validate this update in StandardMagenticManagerTests (unit-test)
github-actions
Bot
changed the title
Collaborator
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
moonbox3
approved these changes
Aug 4, 2025
crickman
approved these changes
Aug 4, 2025
TaoChenOSU
deleted the
taochen/dotnet-magentic-return-last-agent-message
branch
github-project-automation
Bot
moved this from Sprint: In Review
to Sprint: Done
in Semantic Kernel
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
… when limits reached (microsoft#12839) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related to microsoft#12687 Related to microsoft#12656 Currently, the Magentic orchestration returns a static message if the max reset limit or the max invocation limit is reached. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Return the last agent response if either of the limit is reached. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Related to #12687
Related to #12656
Currently, the Magentic orchestration returns a static message if the max reset limit or the max invocation limit is reached.
Description
Return the last agent response if either of the limit is reached.
Contribution Checklist