Skip to content

Python: Add bedrock model provider parameter#12853

Merged
TaoChenOSU merged 3 commits into
mainfrom
taochen/python-add-bedrock-model-provider-param
Aug 5, 2025
Merged

Python: Add bedrock model provider parameter#12853
TaoChenOSU merged 3 commits into
mainfrom
taochen/python-add-bedrock-model-provider-param

Conversation

@TaoChenOSU

@TaoChenOSU TaoChenOSU commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

Fixes #12833

Description

Add an optional setting to the Bedrock AI connectors to allow users to specify the Bedrock model providers (i.e. amazon, anthropic, etc) so that they can use application inference profiles.

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this Aug 4, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner August 4, 2025 21:20
@TaoChenOSU TaoChenOSU added python Pull requests for the Python Semantic Kernel ai connector Anything related to AI connectors labels Aug 4, 2025
@github-actions github-actions Bot changed the title Add bedrock model provider parameter Python: Add bedrock model provider parameter Aug 4, 2025
@moonbox3

moonbox3 commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
connectors/ai/bedrock
   bedrock_settings.py110100% 
connectors/ai/bedrock/services
   bedrock_base.py120100% 
   bedrock_chat_completion.py1321489%115, 132, 157, 161–164, 222, 240–241, 248–249, 257, 316
   bedrock_text_completion.py53296%99, 123
   bedrock_text_embedding.py39197%91
connectors/ai/bedrock/services/model_provider
   bedrock_model_provider.py440100% 
TOTAL26787460982% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3679 22 💤 0 ❌ 0 🔥 1m 58s ⏱️

@TaoChenOSU TaoChenOSU enabled auto-merge August 4, 2025 22:20
Comment thread python/semantic_kernel/connectors/ai/bedrock/README.md Outdated
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 8336c32 Aug 5, 2025
28 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/python-add-bedrock-model-provider-param branch August 5, 2025 00:50
@github-project-automation github-project-automation Bot moved this to Sprint: Done in Semantic Kernel Aug 5, 2025
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes microsoft#12833 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Add an optional setting to the Bedrock AI connectors to allow users to
specify the Bedrock model providers (i.e. amazon, anthropic, etc) so
that they can use application inference profiles.


### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai connector Anything related to AI connectors documentation python Pull requests for the Python Semantic Kernel

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Python: Bug: BedrockChatCompletion does not support Bedrock Application Inference Profiles

3 participants