Skip to content

Python: fix parsing of types in mcp server#12871

Merged
eavanvalkenburg merged 1 commit into
microsoft:mainfrom
eavanvalkenburg:mcp_image_fix
Aug 7, 2025
Merged

Python: fix parsing of types in mcp server#12871
eavanvalkenburg merged 1 commit into
microsoft:mainfrom
eavanvalkenburg:mcp_image_fix

Conversation

@eavanvalkenburg

@eavanvalkenburg eavanvalkenburg commented Aug 6, 2025

Copy link
Copy Markdown
Member

Motivation and Context

The parsing of tool call output was not working correctly, this fixes that.
Solves #12850

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner August 6, 2025 09:16
@moonbox3 moonbox3 added the python Pull requests for the Python Semantic Kernel label Aug 6, 2025
@moonbox3

moonbox3 commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
connectors
   mcp.py42320751%75, 87, 95–102, 108–109, 114, 126–133, 141–145, 147–148, 150, 157–159, 244–250, 285–287, 292–294, 308–309, 312–313, 321–323, 335–336, 340–341, 343, 345, 347–353, 357–359, 361–371, 375–376, 380–381, 385, 387, 391–392, 396, 410, 425–433, 439–440, 442–443, 446–447, 453–454, 469–470, 473–474, 477–482, 486–487, 490–491, 494–500, 574, 576, 643, 645, 647, 649, 718, 720, 722, 724, 726, 784, 827–832, 834–837, 842, 895, 897, 900, 913, 933–935, 942–947, 950–953, 956–958, 962–966, 969–970, 979–980, 982–984, 998–999, 1001–1002, 1004–1006, 1009, 1016–1019, 1027, 1032–1037, 1042, 1044, 1047–1050
TOTAL26790458782% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3680 22 💤 0 ❌ 0 🔥 2m 0s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Aug 7, 2025
Merged via the queue into microsoft:main with commit a6b5f34 Aug 7, 2025
30 checks passed
@eavanvalkenburg eavanvalkenburg deleted the mcp_image_fix branch August 7, 2025 21:57
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
The parsing of tool call output was not working correctly, this fixes
that.
Solves microsoft#12850 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants