Skip to content

.Net: Fix serialization/deserialization bug in InMemory VectorStore Extensions#12878

Merged
westey-m merged 1 commit into
microsoft:mainfrom
westey-m:inmemory-json-roundtrip-bugfix
Aug 11, 2025
Merged

.Net: Fix serialization/deserialization bug in InMemory VectorStore Extensions#12878
westey-m merged 1 commit into
microsoft:mainfrom
westey-m:inmemory-json-roundtrip-bugfix

Conversation

@westey-m

@westey-m westey-m commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

Description

  • Fixing bug where serialized data includes updated internal storage type but deserialization did not.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner August 6, 2025 15:30
@moonbox3 moonbox3 added the .NET Issue or Pull requests regarding .NET code label Aug 6, 2025
@github-actions github-actions Bot changed the title Fix serialization/deserialization bug in InMemory VectorStore Extensions .Net: Fix serialization/deserialization bug in InMemory VectorStore Extensions Aug 6, 2025
@westey-m westey-m added this pull request to the merge queue Aug 11, 2025
Merged via the queue into microsoft:main with commit 4b60913 Aug 11, 2025
21 checks passed
@westey-m westey-m deleted the inmemory-json-roundtrip-bugfix branch August 11, 2025 09:57
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
…xtensions (microsoft#12878)

### Motivation and Context

- Fixes microsoft#12826

### Description

- Fixing bug where serialized data includes updated internal storage
type but deserialization did not.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.Net: Bug: InMemoryVectorStore DeserializeCollectionFromJsonAsync error

5 participants