.Net: Fixed sorting for negative DOT product#13071
Merged
Merged
Conversation
Contributor
|
Hi @yorek, thanks for the contribution, it makes sense. Do you mind also updating the integration test? It is also incorrect. It looks like the only other DB that uses this test is Weaviate, which has been overridden to correctly test the order. // Incorrect order:
this.SimpleSearch(DistanceFunction.NegativeDotProductSimilarity, -1, 1, 0, [1, 2, 0]);
// Correct order:
this.SimpleSearch(DistanceFunction.NegativeDotProductSimilarity, -1, 1, 0, [0, 2, 1]); |
markwallace-microsoft
approved these changes
Sep 10, 2025
rogerbarreto
approved these changes
Sep 10, 2025
Author
|
Thanks everyone for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using negative dot product scoring, the more negative the value, the closer the vector is to the query vector.
Description
Fixed the sorting used for negative dot product distance calculations
Contribution Checklist