.Net: Add instructions checks to ToChatOptions#13169
Merged
Merged
Conversation
This mechanism should really be done in a polymorphic way so as to enable the derived PromptExecutionSettings to control how the ChatOptions is configured. But for now, this can be extended to recognize known names of instructions.
moonbox3
added
.NET
stephentoub
temporarily deployed
to
integration
GitHub Actions
Inactive
github-actions
Bot
changed the title
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
approved these changes
Sep 25, 2025
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Sep 25, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mechanism should really be done in a polymorphic way so as to enable the derived PromptExecutionSettings to control how the ChatOptions is configured. But for now, this can be extended to recognize known names of instructions.
Fixes #13150