.Net: Fix #13262: GeminiRequest to handle single turn requests correctly#13288
Merged
rogerbarreto merged 5 commits intoDec 2, 2025
Merged
Conversation
…rectly Updated the `CreateGeminiRequest` to ensure that single turn requests end with a "user" role or no role
markwallace-microsoft
approved these changes
Nov 3, 2025
Contributor
|
@icyca this PR is still a draft, are you still working on it? |
markwallace-microsoft
self-requested a review
November 3, 2025 12:57
Contributor
Author
|
@markwallace-microsoft No, it is done. I just had it as draft in case it needed further discussion. I will publish it now |
icyca
marked this pull request as ready for review
November 3, 2025 13:01
Contributor
Author
|
@markwallace-microsoft added unit tests |
…nto orchestration-gemini-role-issue
rogerbarreto
had a problem deploying
to
integration
December 2, 2025 11:36 — with
GitHub Actions
Failure
rogerbarreto
approved these changes
Dec 2, 2025
rogerbarreto
temporarily deployed
to
integration
December 2, 2025 11:56 — with
GitHub Actions
Inactive
rogerbarreto
enabled auto-merge
December 2, 2025 12:26
markwallace-microsoft
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the
CreateGeminiRequestto ensure that single turn requests end with a "user" role or no roleMotivation and Context
Description
Removes role from single assistant messages in Gemini requests (Gemini treats no role as user input). Only affects Gemini connector, preserves multi-turn conversations, no breaking changes.
Basically this is a specific case solution to keep Gemini API satisfied.
Contribution Checklist