Skip to content

Remove legacy ffmpeg frame fallback - #69

Merged
adilei merged 1 commit into
release/0.6.0from
adilei-fix-legacy-ffmpeg-timeout
Aug 24, 2026
Merged

Remove legacy ffmpeg frame fallback#69
adilei merged 1 commit into
release/0.6.0from
adilei-fix-legacy-ffmpeg-timeout

Conversation

@adilei

@adilei adilei commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the system-ffmpeg fallback used only by recordings predating captured source frames
  • use captured-frame manifests exclusively and skip frame enrichment gracefully when they are unavailable
  • add a session-level regression proving video-only sessions never attempt ffmpeg discovery and still produce their bundle and description

Why remove instead of time out

Captured-frame manifests have shipped in every tagged release since v0.1.0. Keeping the fallback would add timeout, process-kill, partial-output cleanup, and test-injection machinery solely for unreleased development-era sessions. Removing it eliminates both the indefinite hang in #14 and the orphaned partial-output path tracked in #11 (L6).

Testing

  • targeted extractor and pipeline tests: 8 passed
  • npm run typecheck
  • npm test: 176 passed
  • npm run build

Closes #14.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fe68a1a8-e1d5-408b-b178-b3b4136f1490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant