add 'coverage' dev-dependency and update CONTRIBUTING.md#9
Open
stevengum wants to merge 4 commits intomicrosoft:mainfrom
Open
add 'coverage' dev-dependency and update CONTRIBUTING.md#9stevengum wants to merge 4 commits intomicrosoft:mainfrom
stevengum wants to merge 4 commits intomicrosoft:mainfrom
Conversation
heyitsaamir
reviewed
Dec 9, 2024
| [tool.uv] | ||
| package = false | ||
| dev-dependencies = [ | ||
| "coverage>=7.6.9", |
Collaborator
There was a problem hiding this comment.
I don't know if coverage details are that important at this stage of the project. But feel free to include it and have it run as a github action.
Member
Author
There was a problem hiding this comment.
I agree with your point, but I think it's a good for two scenarios:
- setting up a quality bar for the team to enforce later on (I say later on because it's important for the team to move quickly now)
- people who aren't part of the core team can contribute via tests and learn the codebase
Collaborator
There was a problem hiding this comment.
Hey @stevengum, if you still have bandwidth, could you rebase this? We'd love to merge this in
Contributor
|
Some failed tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example code coverage report in html format:
