Hosting changes: refactoring & support no-auth setup scenario#384
Hosting changes: refactoring & support no-auth setup scenario#384
Conversation
|
from the screenshots, seems we are duplicating the same Warning multiple times. Can we review those logs to have a single entry? |
rido-min
left a comment
rido-min
left a comment
There was a problem hiding this comment.
LGTM, but I'd like to validate in a real environment with UMI and FIC before merging
| return services.AddUserTokenClient(botConfig); | ||
| } | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
nit: we are not adding XML comments to private members
| TenantId = section["TenantId"] ?? string.Empty, | ||
| ClientId = section["ClientId"] ?? string.Empty, | ||
| ClientSecret = section["ClientSecret"], | ||
| Scope = section["Scope"] ?? configuration["Scope"] ?? BotScope, |
There was a problem hiding this comment.
we need to clarify where to read the Scope from, seems we are reading from the root, and from the section
| /// <summary> | ||
| /// Configures MSAL with User-Assigned Managed Identity (UMI) authentication. | ||
| /// </summary> | ||
| private static IServiceCollection ConfigureMSALWithUMI(this IServiceCollection services, string tenantId, string clientId, string? managedIdentityClientId = null) |
There was a problem hiding this comment.
UMI is not easy to validate, do you need any help to configure and validate?
yeah, i will do another pass of refactoring to avoid redundant log statements |
2 participants
RequireAuthorizationin CompatBot sample.BotConfigas single source for reading & propagating configuration instead of doing that all over.Logs when setting up auth using the different config formats
No credentials setup
Msal Config setup
Core config setup
BF config setup