Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next/core port of #389 — quoted replies support adapted to core conventions.
Changes (matching #389)
QuotedReplyEntitywith nestedQuotedReplyData(MessageIdrequired,SenderId/SenderName/Preview/Time/IsReplyDeleted/ValidatedMessageReferenceoptional); register inEntityList.FromJsonArray()type switch andTeamsActivityJsonContextGetQuotedMessages()extension onTeamsActivityto read inbound quoted reply entitiesAddQuotedReply(messageId, response?)extension onTeamsActivityWithQuotedReply(messageId, response?)onTeamsActivityBuilderReplyAsync()onContextto stampQuotedReplyEntity+<quoted messageId="..."/>placeholder (auto-quotes inbound message)QuoteReplyAsync()onContextto quote a specific message by IDWithReplyToId()fromCoreActivityBuilderand its call inWithConversationReference()ReplyToIdURL append inConversationClient.SendActivityAsync()[Experimental("ExperimentalTeamsQuotedReplies")]QuotedRepliessample exercising all APIsDeviations from #389 (next/core conventions)
QuotedReplyEntityusesPropertiesdictionary backing store (not direct JSON properties) — matchesMentionEntity,ClientInfoEntityGetQuotedMessages()andAddQuotedReply()are extension methods onTeamsActivity(not instance methods onMessageActivity) — matchesGetMentions(),AddMention()patternWithQuotedReply()added toTeamsActivityBuilder(main hasAddQuotedReply()onMessageActivitydirectly)ReplyAsync()/QuoteReplyAsync()(new methods, main modifies existingReply())WithReplyToId()removal: Broader scope in next/core — also removed dead URL construction inConversationClientand theWithConversationReference()callToQuoteReply()deprecation: Method never existed in next/core;messageid=stripping removal: Pattern never existed in next/coreRebase()calls: Required after entity mutation to syncEntityListback to baseJsonArrayQuotedReplyEntityandQuotedReplyDataregistered inTeamsActivityJsonContextNoWarn:ExperimentalTeamsQuotedRepliessuppressed in Apps.csproj(required for source-generated JSON code)Test plan
🤖 Generated with Claude Code