Skip to content

Move internal workspace packages from peer deps to direct deps #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heyitsaamir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move internal workspace packages from peer deps to direct deps #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/a2a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@microsoft/teams.a2a": "*",
"@microsoft/teams.ai": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.openai": "*"
},
Expand Down
1 change: 0 additions & 1 deletion examples/ai/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"@microsoft/teams.ai": "*",
"@microsoft/teams.openai": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.cards": "*",
"fuse.js": "^7.1.0"
},
"devDependencies": {
Expand Down
4 changes: 0 additions & 4 deletions examples/botbuilder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,9 @@
"dev": "tsx watch -r dotenv/config src/index.ts"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.botbuilder": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*",
"botbuilder": "4.23.1"
},
"devDependencies": {
Expand Down
1 change: 0 additions & 1 deletion examples/cards/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
},
"dependencies": {
"@microsoft/teams.apps": "*",
"@microsoft/teams.ai": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.cards": "*"
},
Expand Down
1 change: 0 additions & 1 deletion examples/dialogs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"dev:teamsfx:launch-testtool": "npx env-cmd --silent -f env/.env.testtool teamsapptester start"
},
"dependencies": {
"@microsoft/teams.ai": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.dev": "*"
Expand Down
6 changes: 1 addition & 5 deletions examples/echo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,8 @@
"dev:teamsfx:launch-testtool": "npx env-cmd --silent -f env/.env.testtool teamsapptester start"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*"
"@microsoft/teams.dev": "*"
},
"devDependencies": {
"@microsoft/teams.config": "*",
Expand Down
5 changes: 0 additions & 5 deletions examples/graph/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@
"dev:teamsfx:launch-testtool": "npx env-cmd --silent -f env/.env.testtool teamsapptester start"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*",
"@microsoft/teams.graph-endpoints": "*"
},
"devDependencies": {
Expand Down
4 changes: 0 additions & 4 deletions examples/lights/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,8 @@
},
"dependencies": {
"@microsoft/teams.ai": "*",
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*",
"@microsoft/teams.openai": "*"
},
"devDependencies": {
Expand Down
5 changes: 0 additions & 5 deletions examples/mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,9 @@
"dev:teamsfx:launch-testtool": "npx env-cmd --silent -f env/.env.testtool teamsapptester start"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*",
"@microsoft/teams.mcp": "*",
"@microsoft/teams.openai": "*",
"@modelcontextprotocol/sdk": "^1.25.2",
"zod": "^3.24.3"
},
Expand Down
2 changes: 0 additions & 2 deletions examples/meetings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@
"dev": "tsx watch -r dotenv/config src/index.ts"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.cards": "*"
},
"devDependencies": {
Expand Down
5 changes: 1 addition & 4 deletions examples/message-extensions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,9 @@
"dev": "tsx watch -r dotenv/config src/index.ts"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*"
"@microsoft/teams.dev": "*"
},
"devDependencies": {
"@microsoft/teams.config": "*",
Expand Down
7 changes: 1 addition & 6 deletions examples/reactions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@
"dev:teamsfx:launch-testtool": "npx env-cmd --silent -f env/.env.testtool teamsapptester start"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*"
"@microsoft/teams.apps": "*"
},
"devDependencies": {
"@microsoft/teams.config": "*",
Expand Down
4 changes: 0 additions & 4 deletions examples/tab/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,9 @@
"build:client": "npx vite build --outDir dist/client"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.client": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@microsoft/teams.graph": "*",
"@microsoft/teams.graph-endpoints": "*",
"react": "^19.2.2",
"react-dom": "^19.2.2"
Expand Down
3 changes: 0 additions & 3 deletions examples/targeted-messages/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,7 @@
"dev": "tsx watch -r dotenv/config src/index.ts"
},
"dependencies": {
"@microsoft/teams.api": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.cards": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*"
},
"devDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions external/a2a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@
},
"peerDependencies": {
"@a2a-js/sdk": "^0.3.4",
"@microsoft/teams.ai": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.common": "*"
"@microsoft/teams.apps": "*"
},
"devDependencies": {
"@microsoft/teams.config": "*",
Expand All @@ -45,6 +43,8 @@
"typescript": "^5.4.5"
},
"dependencies": {
"@microsoft/teams.ai": "*",
"@microsoft/teams.common": "*",
"lodash.camelcase": "^4.3.0"
}
}
10 changes: 2 additions & 8 deletions external/mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,15 @@
"test": "npx jest"
},
"dependencies": {
"@microsoft/teams.ai": "*",
"@microsoft/teams.common": "*",
"json-schema-to-zod": "^2.6.0",
"zod": "^3.24.2"
},
"peerDependencies": {
"@microsoft/teams.ai": "*",
"@microsoft/teams.apps": "*",
"@microsoft/teams.common": "*",
"@microsoft/teams.dev": "*",
"@modelcontextprotocol/sdk": "^1.9.0"
},
"peerDependenciesMeta": {
"@microsoft/teams.dev": {
"optional": true
}
},
"devDependencies": {
"@microsoft/teams.config": "*",
"@types/jest": "^29.5.12",
Expand Down
10 changes: 0 additions & 10 deletions external/mcp/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
Plugin,
} from '@microsoft/teams.apps';
import { ILogger } from '@microsoft/teams.common';
import { DevtoolsPlugin } from '@microsoft/teams.dev';

import pkg from '../package.json';

Expand Down Expand Up @@ -114,9 +113,6 @@ export class McpPlugin implements IPlugin {
@Dependency()
readonly httpPlugin!: HttpPlugin;

@Dependency({ optional: true })
readonly devtoolsPlugin?: DevtoolsPlugin;

readonly server: McpServer;
protected id: number = -1;
protected inspector: string;
Expand Down Expand Up @@ -191,12 +187,6 @@ export class McpPlugin implements IPlugin {
}

onInit() {
this.devtoolsPlugin?.addPage({
name: 'mcp',
displayName: 'MCP',
url: this.inspector,
});

if (this.transport.type === 'sse') {
return this.onInitSSE(this.httpPlugin, this.transport);
}
Expand Down
6 changes: 4 additions & 2 deletions external/mcpclient/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@
"build": "npx tsup",
"test": "npx jest"
},
"dependencies": {
"@microsoft/teams.common": "*"
},
"peerDependencies": {
"@modelcontextprotocol/sdk": "^1.13.0",
"@microsoft/teams.ai": "*",
"@microsoft/teams.common": "*"
"@modelcontextprotocol/sdk": "^1.13.0"
},
"devDependencies": {
"@microsoft/teams.config": "*",
Expand Down
Loading
Loading