Update Microsoft.NETTestSdkVersion and related packages - #11178
Amaury Levé (Evangelink) wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The version alignment is complete, valid, and leaves no stale property references.
Review tier: Balanced
Findings: None
What changed in this PR
Aligns the .NET test SDK and related Test Platform packages on version 18.10.0.
Changes:
- Updates
MicrosoftNETTestSdkVersionto 18.10.0. - Removes the redundant Filter.Source version property.
| File | Description |
|---|---|
Directory.Packages.props |
Centralizes related Test Platform packages on version 18.10.0. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Direct TestPlatform references in acceptance tests still resolve version 18.9.0.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
Directory.Packages.props — The version split is not propagated to acceptance-test consumers that reference TestPlatform… |
This comment has been minimized.
This comment has been minimized.
|
Final test-triage resolution — Azure Pipelines build 1591340 Status: final (completed aggregate build, This confirms and extends the preliminary finding for this build. All three legs (
No retries recovered any of these; each fails once and stays failed on every leg. The identical signature also recurred on this PR's prior build (1590874's preliminary comment flagged it on the Linux leg alone; this build confirms it now reproduces on macOS and Windows too), so this is a stable regression tied to the current revision rather than a one-off environmental flake. Root cause: this PR only changes Because this failure is caused by and confined to this PR's own incomplete package-version split — not a pre-existing or general codebase defect — no new issue is warranted; the fix is to complete the Next step: apply the outstanding review-comment fix (route
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The publish cleanup risks deleting required assemblies, and Test Platform asset resolution still uses the outdated version source.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets — Wildcard cleanup deletes legitimate self-contained runtime files |
Pre-existing issues (1)
| Severity | Finding |
|---|---|
Directory.Packages.props — The version split is not propagated to acceptance-test consumers that reference TestPlatform… View comment |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🧵 Parallel-safety audit — PR #11178Nothing audited here touches process-global state, shared filesystem paths, or The two changed test files ( Audited Re-run with
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review tier: Lite
Findings: None
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets — Wildcard cleanup deletes legitimate self-contained runtime files View resolved comment |
|
Directory.Packages.props — The version split is not propagated to acceptance-test consumers that reference TestPlatform… View resolved comment |
🧪 Expert test review — PR #11178Both changed test files land their edits entirely inside asset-generator helper methods or in a single one-line swap of the injected MSBuild source string — no assertion logic, control flow, or test intent changed.
No This advisory comment was generated automatically. Grades are heuristic
|
Pull request was closed


No description provided.