Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameterized UI tests for WinUI #5305

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Mar 24, 2025

We should pass null so that we fallback to Arguments which has the right thing for parameterized tests:

Fixes #740

It looks like we don't have the test infra that allows to test this, as we need vstest.console.exe that comes with VS. It should be possible to test it, but requires a bit of test infra work.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (d991da7) to head (a6c5074).

Files with missing lines Patch % Lines
...tensions/Attributes/WinUI_UITestMethodAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5305      +/-   ##
==========================================
- Coverage   75.28%   72.91%   -2.38%     
==========================================
  Files         601      601              
  Lines       37673    37672       -1     
==========================================
- Hits        28363    27469     -894     
- Misses       9310    10203     +893     
Flag Coverage Δ
Debug 72.91% <0.00%> (-2.38%) ⬇️
integration 72.91% <0.00%> (-2.38%) ⬇️
production 72.91% <0.00%> (-2.38%) ⬇️
unit 72.91% <0.00%> (-2.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tensions/Attributes/WinUI_UITestMethodAttribute.cs 0.00% <0.00%> (ø)

... and 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313 Youssef1313 merged commit 6870397 into main Mar 24, 2025
9 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/fix-invoke-winui branch March 24, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: UIDataTestMethod / Support for DataRows in UITestMethods
3 participants