-
Notifications
You must be signed in to change notification settings - Fork 280
Add field support to DynamicDataAttribute #6203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
DynamicDataAttribute
to accept a public static class field
Copilot finished work on behalf of
Evangelink
July 28, 2025 12:48
Evangelink
reviewed
Jul 28, 2025
Co-authored-by: Evangelink <[email protected]>
Copilot finished work on behalf of
Evangelink
July 28, 2025 20:22
# Conflicts: # src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Youssef1313
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for public static fields as data sources in
DynamicDataAttribute
, addressing a key performance improvement request for test data management.Problem
Previously,
DynamicDataAttribute
only supported properties and methods as data sources. This meant that even for constant test data, new objects were created on each access due to property getters or method calls, despite being static:Solution
Added comprehensive support for static fields as data sources, allowing truly constant test data:
Key Features
DynamicDataSourceType.Field
for direct field targetingImplementation Details
DynamicDataSourceType
enum withField = 3
optionDynamicDataOperations
Backward Compatibility
This change is fully backward compatible - all existing code continues to work exactly as before. The new field support is purely additive functionality.
Fixes #5321.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
37cvsblobprodcus359.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)4zjvsblobprodcus390.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)7devsblobprodcus323.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)l49vsblobprodcus358.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)ljcvsblobprodcus317.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)sqdvsblobprodcus333.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)st8vsblobprodcus339.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)ytvvsblobprodcus310.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.