fix: remove checkout:self and fix paths for OneBranch checkout convention - #59
Merged
Merged
Conversation
Two fixes: 1. Remove checkout: self (causes .pid file deletion, breaking signing) 2. Update all $(Build.SourcesDirectory)\tgrep paths to \s (OneBranch auto-checkout puts source in \s subdirectory)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OneBranch sign-and-release Azure DevOps workflow to match OneBranch’s auto-checkout behavior and avoid breaking the signing FileWatcher, so the Windows build/sign/package steps can run successfully.
Changes:
- Removed explicit
checkout: selfusage (relying on OneBranch auto-checkout). - Updated workflow paths from
$(Build.SourcesDirectory)\tgrepto$(Build.SourcesDirectory)\s. - Updated CargoAuthenticate
configFileto point ats/.cargo/config.toml.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/sign-and-release.yml | Removes explicit checkout and rewires build/sign/package paths to the OneBranch s checkout location, including CargoAuthenticate config path. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
msftsiwei
enabled auto-merge
April 20, 2026 09:19
Shengyu Fu (shengyfu)
approved these changes
Apr 20, 2026
msftsiwei
added a commit
that referenced
this pull request
Apr 20, 2026
…y the source root PR #59 incorrectly added \s suffix to $(Build.SourcesDirectory), causing double-path like C:\__w\1\s\s\.cargo. The variable already points to the source root directly (C:\__w\1\s), so no subdirectory suffix needed.
msftsiwei
added a commit
that referenced
this pull request
Apr 20, 2026
The arm64 cross-compile job only builds aarch64-pc-windows-msvc target, so it does not need [target.x86_64-pc-windows-msvc] rustflags in its cargo config. Having x86_64 rustflags (including /CETCOMPAT) in the arm64 job's config causes CargoAuthenticate@0 to propagate them to CARGO_HOME/config.toml, which then gets merged with the arm64 config during compilation, resulting in: LNK1246: '/CETCOMPAT' not compatible with 'ARM64' target machine Note: PR #59's \s path fixes were correct and are preserved here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues were causing the sign-and-release pipeline to fail:
checkout: selfdeletes the OneBranch.pidfile, causing the signing step to fail (documented in OneBranch Signing FileWatcher FAQ)All paths used
$(Build.SourcesDirectory)\tgrepbut OneBranch auto-checkout puts source in$(Build.SourcesDirectory)\s(confirmed from build log: task name is "Checkout microsoft/tgrep@main to s")Fix
checkout: selfblocks (OneBranch handles checkout automatically)\tgrepto\sconfigFile: 'tgrep/.cargo/config.toml'to's/.cargo/config.toml'