Added support for simple atomic_rmw #351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
tt.atomic_rmwoperations that work with scalars. I implemented a simple conversion fromtt.atomic_rmwtomemref.atomic_rmwinReconcilePtrCastsPass.cpp. I believe this is the most appropriate place for the code, but I’m open to feedback if there’s a better alternative.Support for
tt.atomic_rmwwith tensors can also be added in the future, but that would require converting them tomemref.generic_atomic_rmw, which needs some additional work.This is my first PR to this repository, so I’d appreciate any feedback and hope to contribute more to this project!