Skip to content

Bump to triton-lang/triton@dbfbc1e1e6c #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
enjustli wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump to triton-lang/triton@dbfbc1e1e6c #363

enjustli wants to merge 3 commits into from

Conversation

@enjustli
Copy link
Contributor

@enjustli enjustli commented Nov 15, 2025 •
edited
Loading

This updates to latest Triton main which should resolve the nightly build issues.

Primary changes:

  • Change llvm/mlir api usage
  • Update driver.py

@enjustli
Copy link
Contributor Author

enjustli commented Nov 15, 2025 •
edited
Loading

this PR needs triton-lang/triton#8766 merged

@enjustli enjustli changed the title Bump triton to 3543fe1d52dd84fd4e5b792f916cafe2824e46ea Bump triton to 3543fe1d52dd Nov 20, 2025
@enjustli enjustli changed the title Bump triton to 3543fe1d52dd Bump to triton@3543fe1d52dd Nov 20, 2025
@enjustli enjustli changed the title Bump to triton@3543fe1d52dd Bump to triton@acd81049917c Nov 22, 2025
@enjustli enjustli marked this pull request as ready for review November 22, 2025 04:26
@enjustli
Copy link
Contributor Author

enjustli commented Nov 22, 2025

@nhat-nguyen, sorry for the explicit ping but I did not have access to request a formal review. Could you be pleaase review the PR / or request review from appropriate stakeholders?
Thanks!

@enjustli enjustli mentioned this pull request Nov 24, 2025
Open
@enjustli
Copy link
Contributor Author

enjustli commented Nov 25, 2025

gently pin

@nhat-nguyen
Copy link
Contributor

nhat-nguyen commented Nov 25, 2025

the api changes for op creation and driver.py look good to me. thanks a lot for helping us update this! as for the lit tests, do you know what are the main changes that caused the differences?

tangentially, we're not using the triton-to-linalg pass anymore (triton-to-linalg-experimental is the main one now), so it might be cleaner to remove the pass and those tests first before the triton bump so that we don't have to update the lit files.

@enjustli
Copy link
Contributor Author

enjustli commented Nov 26, 2025

the api changes for op creation and driver.py look good to me. thanks a lot for helping us update this! as for the lit tests, do you know what are the main changes that caused the differences?

tangentially, we're not using the triton-to-linalg pass anymore (triton-to-linalg-experimental is the main one now), so it might be cleaner to remove the pass and those tests first before the triton bump so that we don't have to update the lit files.

In the new llvm version, memref.reinterpret_cast enhances the analysis of static offset. so the output IR changed. due to too many changed mlir files, so i use llvm-project/mlir/utils/generate-test-checks.py to generate mlir CHECK directly.

removing the triton-to-linalg pass helps a lot! 🎉

@enjustli
Copy link
Contributor Author

enjustli commented Nov 26, 2025

already update.

@enjustli
Copy link
Contributor Author

enjustli commented Dec 1, 2025

gently pin

@enjustli enjustli changed the title Bump to triton@acd81049917c Bump to triton-lang/triton@acd81049917c Dec 1, 2025
@enjustli
Copy link
Contributor Author

enjustli commented Dec 2, 2025

ping @bmyerz0 @red1bluelost

@nhat-nguyen
Copy link
Contributor

nhat-nguyen commented Dec 2, 2025

i think it would be cleaner if we delete the TritonToLinalg pass in a different PR

@enjustli
Copy link
Contributor Author

enjustli commented Dec 3, 2025

i think it would be cleaner if we delete the TritonToLinalg pass in a different PR

I see. 👌

@enjustli enjustli force-pushed the bump_triton branch 2 times, most recently from 04c7627 to 1c5906e Compare December 3, 2025 04:19
@enjustli enjustli changed the title Bump to triton-lang/triton@acd81049917c Bump to triton-lang/triton@e184cffdf7b Dec 3, 2025
@enjustli
Copy link
Contributor Author

enjustli commented Dec 3, 2025

this pr depends on #366

@enjustli
Update triton to dbfbc1e1e6c
4f593cb 
bypass bf16 type

update api usage for llvm version change

update backend

update test case
@enjustli
Bump to triton-lang/triton@dbfbc1e1e6c
422b446
@enjustli enjustli changed the title Bump to triton-lang/triton@e184cffdf7b Bump to triton-lang/triton@dbfbc1e1e6c Dec 4, 2025
@bmyerz0
Copy link
Contributor

bmyerz0 commented Dec 5, 2025

Please see #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enjustli @nhat-nguyen @bmyerz0