autoimport completions #1553
autoimport completions #1553
Conversation
|
I'm gonna closely follow this one... |
|
bug squashing atm :). Hopefully it'll be ready soon |
There was a problem hiding this comment.
Pull Request Overview
This PR implements autoimports functionality, enabling automatic import suggestions through completions in the TypeScript language server. The implementation adds the ability to suggest and automatically import symbols from other modules when typing identifiers.
Key changes include:
- Added comprehensive autoimport completion system with export info mapping and module specifier resolution
- Implemented import statement completion support for various import syntaxes
- Added text change tracking infrastructure for code modifications
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/ls/completions.go |
Main autoimport logic including export collection, module specifier resolution, and completion item generation |
internal/ls/autoimportstypes.go |
Type definitions for import/export kinds, import fixes, and related data structures |
internal/ls/changetrackerimpl.go |
Change tracking implementation for applying text edits and code modifications |
internal/printer/changetrackerwriter.go |
Writer implementation for tracking position changes during code generation |
internal/modulespecifiers/specifiers.go |
Enhanced module specifier generation with autoimport support |
internal/ls/organizeimports.go |
Import organization utilities and comparison functions |
| Various utility files | Helper functions, type conversions, and API enhancements to support autoimport functionality |
| @@ -139,7 +139,7 @@ func getActualIndentationForListItem(node *ast.Node, sourceFile *ast.SourceFile, | |||
| // VariableDeclarationList has no wrapping tokens | |||
| return -1 | |||
| } | |||
| containingList := getContainingList(node, sourceFile) | |||
| containingList := GetContainingList(node, sourceFile) | |||
There was a problem hiding this comment.
I didn't know this func existed; I wonder if it's general enough to use for sig help. (No action needed, just opining)
| } | ||
|
|
||
| func findFirstNonWhitespaceColumn(startPos int, endPos int, sourceFile *ast.SourceFile, options *FormatCodeSettings) int { | ||
| func FindFirstNonWhitespaceColumn(startPos int, endPos int, sourceFile *ast.SourceFile, options *FormatCodeSettings) int { |
There was a problem hiding this comment.
I am suspicious of this function, given it appears to return the column in terms of runes? I'm not sure it walks the chars correctly either, hmm...
There was a problem hiding this comment.
This is what I was writing when I first went "wait, do we work in runes or in byte offsets for columns? Looks inconsistent right now". Both ways look wrong to some part of the stack around here because of that inconsistency.
There was a problem hiding this comment.
Yeah, I think we need everything to be UTF-8 byte offsets, until they hit the LS and get converted based on the client preferences.
The only exception might be symbol baselines (UTF-16 compat?), source maps, and maybe the API, and maybe printed diagnostics? (That's a lot of exceptions...)
Related, #1578
|
The import in the demo is inserted in a non-pretty way; is that something being worked on? |
Yes, this is a formatting bug/limitation. Strada formats with a Edit: Fixed with help from @weswigham New statements come out pretty now (haven't updated the demo vid yet tho) |
internal/fourslash/tests/gen/completionsObjectLiteralModuleExports_test.go
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,145 @@ | |||
| package fourslash_test | |||
There was a problem hiding this comment.
Technically the tests in internal/fourslash/tests/manual/ are supposed to be generated tests that had to be manually modified, and new tests go into internal/fourslash/tests/, though that doesn't have practical differences I think other than our own organization of things.
There was a problem hiding this comment.
Yeah, I would suggest moving this file for clarity.
| } | ||
|
|
||
| if defaultImport != nil { | ||
| // Debug.assert(!clause.name, "Cannot add a default import to an import clause that already has one"); |
There was a problem hiding this comment.
If #1593 gets merged before this PR, this can be updated. 🙂
…to generated nodes
| ExportKindModule ExportKind = 4 | ||
| ) | ||
|
|
||
| func (k ExportKind) String() string { |
There was a problem hiding this comment.
You could use stringer to generate this, if you do need the method.
|
Tried it out, nice: 
But, the import did appear with the wrong indent level: 
(I am ignoring the ordering, since that's a different problem.) |
This PR implements autoimports, and allows symbols to be autoimported through completions. Also ports the basic functionalities of the changetracker (adds changes and calculates/formats the output string).
demo (note: the formatting has been fixed, see test cases)
corsa.completion.autoimports.1.mp4
Notes on implementation:
ExportInfoMap,ImportMap, etc) have been ported for functionality, but are not saved between server requests). After the ls is more fully implemented and perf tested, we will revisit to see what caching we need to doIncludeCompletionsForModuleExportsandIncludeCompletionsForImportStatementsin theUserPreferencespassed into any completion get/resolve request has been set totrueto allow autoimports to work autoimport completions #1553 (comment)Related features to be implemented after this PR: