fourslash userpreferences (and fetch inlay hints userpreferences from vscode) #1729

iisaduan · 2025-09-17T22:06:47Z

Goal is to unblock #1705

fourslash supports all userpreferences
userpreferences implemented into server, session, and snapshot/languageService's lifecycles.
only inlay hints preferences are parsed from vscode's client config responses

A full implementation of LSP compliant config getting/updating requires more work in the extension (currently in progress)

jakebailey · 2025-09-17T22:23:37Z

A full implementation of LSP compliant config getting/updating requires more work in the extension (currently in progress)

What is needed? I would think we would just ask for the setting blocks we are interested in and watch them, from the server side (no extension code needed).

iisaduan · 2025-09-17T22:47:05Z

Our userPreferences struct doesn't exist at all in vscode--the previous extension did a lot of processing of the way that vscode's settings.json is represented before it passed a userPreferences to tsserver. We could do this processing on our side, but the code is so much more complicated in go (hence why I didn't implement every preference), and would mean that other clients (if they want to support userPreferences) have to convert their preferences into vscode's preferences, which then our server would convert again. Also, LSP spec says that the client should do this processing.

The other extension changes include to make configuration happen on initialization

jakebailey · 2025-09-17T23:00:47Z

I feel confused. The LSP config spec is exactly the same as asking VS Code for a setting out of JSON. Putting more code in the client is just going to make that same code repeat across editors...

iisaduan · 2025-09-17T23:37:02Z

internal/lsp/server.go

+	result, err := s.sendRequest(ctx, lsproto.MethodWorkspaceConfiguration, &lsproto.ConfigurationParams{
+		Items: []*lsproto.ConfigurationItem{
+			{
+				Section: ptrTo("typescript"),
+			},
+		},
+	})


I think I see what you mean, are you asking if instead of requesting the config for one entry, "typescript", we request a list of preferences, one for every preference area that we expect from vscode:

Suggested change

result, err := s.sendRequest(ctx, lsproto.MethodWorkspaceConfiguration, &lsproto.ConfigurationParams{

Items: []*lsproto.ConfigurationItem{

{

Section: ptrTo("typescript"),

},

},

})

result, err := s.sendRequest(ctx, lsproto.MethodWorkspaceConfiguration, &lsproto.ConfigurationParams{

Items: []*lsproto.ConfigurationItem{

{

Section: ptrTo("typescript.inlayHints"),

},

{

Section: ptrTo("typescript.preferences"),

},

{

Section: ptrTo("typescript.unstable"),

},

.... etc

},

})

and process like that?

or even ask for every individual setting like "typescript.inlayHints.parameterNames.enabled", "typescript.inlayHints.supressWhenTypeMatchesName.enabled", etc

Yes, though I think we have to also request javascript too, and maybe even js/ts?

Then best case, we register a config watch on them and then keep them up to date.

internal/fourslash/fourslash.go

internal/ls/languageservice.go

gabritto · 2025-09-18T18:26:34Z

internal/lsp/server.go

+		if item, ok := config.(map[string]any); ok {
+			for name, values := range item {
+				switch name {
+				case "inlayHints":


I wonder if we could generate this code, maybe from the package.json in the extension when we have that.

Yeah, re: the conversation I had with jake above, I'm doing some thinking about other ways we could do this. This function as-is definitely isn't permanent

gabritto · 2025-09-18T18:30:27Z

internal/lsp/server.go

+func (s *Server) handleDidChangeWorkspaceConfiguration(ctx context.Context, params *lsproto.DidChangeConfigurationParams) error {
+	// !!! update user preferences
+	// !!! only usable by fourslash
+	if item, ok := params.Settings.(*ls.UserPreferences); ok {


Can't we do the same kind of parsing here that we're doing in Configure above?

gabritto · 2025-09-18T19:03:21Z

internal/lsp/server.go

+	if err != nil {
+		return err
+	}
+	s.session.Configure(userPreferences)


Don't we also need to register with the client here to be able to actually get config change notifications? Just like we do in WatchFiles.

Re: this + the comment above (link), I didn't fully implement this function because I wanted to figure out what we're going to process in the extension first and I wasn't sure the range of how much info that the client can pass to the server (will it always pass the entire new config upon changes? or only the differences?)

internal/fourslash/fourslash.go

gabritto · 2025-09-18T19:16:25Z

internal/fourslash/fourslash.go

+
+	// currently, the only request that may be sent by the server during a client request is one `config` request
+	// !!! remove if `config` is handled in initialization and there are no other server-initiated requests
+	if resp.Kind == lsproto.MessageKindRequest {


I do think we should move this handling to initialization. Or are going to need to handle other requests as well?

I'm not sure what we will need in the future

I think you could imagine the fourslash client handling diagnostics refresh requests and potentially even watch requests.

If we're going to port the fourslash/server tests, then those probably will have to be handled?

Copilot

Pull Request Overview

This PR implements user preferences support throughout the codebase to unblock future work, focusing on fourslash test capabilities and inlay hints configuration from VS Code. The implementation adds user preferences handling to the session lifecycle, language service, and LSP server with initial support for parsing inlay hints settings from VS Code client configuration.

Adds user preferences threading through session, snapshot, and language service layers
Implements VS Code configuration parsing for inlay hints preferences
Extends fourslash testing framework to support user preferences configuration

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
internal/project/snapshot.go	Adds user preferences field and getter method to snapshot
internal/project/session.go	Implements user preferences configuration and change tracking in session
internal/project/api.go	Updates API calls to include user preferences parameter
internal/lsp/server.go	Adds configuration request handling and inlay hints parsing from VS Code
internal/ls/types.go	Extends UserPreferences with inlay hints fields and copy methods
internal/ls/languageservice.go	Adds user preferences parameter to language service constructor
internal/fourslash/fourslash.go	Implements user preferences configuration support for testing
internal/fourslash/tests/autoImportCompletion_test.go	Adds test case for user preferences functionality
internal/api/api.go	Updates language service instantiation to include user preferences

internal/lsp/server.go

andrewbranch · 2025-09-26T16:19:54Z

internal/project/snapshot.go

 		session.extendedConfigCache,
 		nil,
 		compilerOptionsForInferredProjects,
+		session.userPreferences,


This is a race—you only protect the boolean session.pendingChanges with the mutex while computing whether you need to do a snapshot update. By the time you get here, session.userPreferences could have changed since that boolean was accessed. You need to lock and extract the actual new value of the user preferences, and then make that part of SnapshotChange.

iisaduan added 2 commits September 17, 2025 14:25

userpreferences

2ace8fe

remove unused fucntiosn

dbfff26

iisaduan requested review from Copilot, andrewbranch and gabritto and removed request for Copilot and andrewbranch September 17, 2025 22:06

iisaduan commented Sep 17, 2025

View reviewed changes

gabritto reviewed Sep 18, 2025

View reviewed changes

fourslash updates

ff140e9

Copilot AI review requested due to automatic review settings September 18, 2025 20:35

Copilot AI reviewed Sep 18, 2025

View reviewed changes

andrewbranch requested changes Sep 26, 2025

View reviewed changes

iisaduan mentioned this pull request Oct 2, 2025

refactor userpreferences #1794

Merged

fourslash userpreferences (and fetch inlay hints userpreferences from vscode) #1729

Are you sure you want to change the base?

fourslash userpreferences (and fetch inlay hints userpreferences from vscode) #1729

Uh oh!

Conversation

iisaduan commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Sep 17, 2025

Uh oh!

iisaduan commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Sep 17, 2025

Uh oh!

iisaduan Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iisaduan Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iisaduan Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iisaduan commented Sep 17, 2025 •

edited

Loading

iisaduan commented Sep 17, 2025 •

edited

Loading

iisaduan Sep 17, 2025 •

edited

Loading

iisaduan Sep 18, 2025 •

edited

Loading

iisaduan Sep 30, 2025 •

edited

Loading