Use Realpath instead of EvalSymlinks for exe dir #2381
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the use of Go's standard library filepath.EvalSymlinks with the custom osvfs.FS().Realpath() function for resolving the executable directory path, likely to fix issue #2375. The changes unify path handling to use the internal tspath and osvfs packages consistently throughout the bundled package.
Key changes:
- Replace
filepath.EvalSymlinkswithosvfs.FS().Realpathfor symlink resolution - Switch from
filepathfunctions totspathequivalents (e.g.,GetDirectoryPath,CombinePaths) - Replace
os.Statwithosvfs.FS().Statfor file existence checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2375