[python] compartmentalize generation-subdir#10254
Merged
iscai-msft merged 3 commits intoMay 1, 2026
Merged
Conversation
iscai-msft
requested review from
ChenxiJiang333,
catalinaperalta,
laiapat,
lmazuel,
msyyc,
swathipil,
tadelesh and
timotheeguerin
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
msyyc
reviewed
Apr 3, 2026
msyyc
reviewed
Apr 3, 2026
msyyc
reviewed
Apr 3, 2026
msyyc
reviewed
Apr 3, 2026
msyyc
reviewed
Apr 3, 2026
msyyc
requested changes
Apr 3, 2026
iscai-msft
force-pushed
the
python/generationSubdirContainment
branch
from
9388122 to
ba3b9a7
Compare
msyyc
approved these changes
Apr 29, 2026
msyyc
left a comment
msyyc
left a comment
Contributor
There was a problem hiding this comment.
Seems only some annotation update in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right now, we're modifying files above the specified
generation-subdir. My belief is that when a user specifiesgeneration-subidr, we don't touch anything. We might want to touch the packaging files, that is debatable though.