fix: prevent crash when package-name option is missing in http-client-csharp#10315
Merged
JonathanCrd merged 3 commits intoApr 9, 2026
Merged
Conversation
JonathanCrd
requested review from
JoshLove-msft,
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
…-csharp - Make package-name optional in C# Configuration with default fallback - Resolve default from PrimaryNamespace in Configure() with info message - Report diagnostics instead of throwing when C# generator fails - Remove ReadRequiredStringOption since no options are required anymore - Add tests for default package name behavior and diagnostic reporting Fixes microsoft#9554 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JonathanCrd
force-pushed
the
fix/csharp-no-options-crash-9554
branch
from
ae26f13 to
c9ce8b6
Compare
commit: |
Contributor
|
No changes needing a change description found. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running the C# emitter with no options (specifically no
package-name), the C# generator crashes with anInvalidOperationExceptioninstead of reporting a diagnostic or using a default.Changes
C# Generator
Configuration.cs: Madepackage-nameoptional with aDefaultPackageNamefallback ("GeneratedClient"). RemovedReadRequiredStringOptionsince no options are required anymore.CodeModelGenerator.cs: InConfigure(), resolves the default fromPrimaryNamespace(code model namespace) and emits an info message — per Josh's suggestion.TypeScript Emitter
emitter.ts: Generator failures now report diagnostics viasdkContext.logger.error()instead of throwing unhandled exceptions.Tests
ConfigurationTests.cs: verify default package name behavior and PrimaryNamespace resolution.Fixes #9554
🤖 Created with JonathanCrd copilot