[Draft] Use hybrid C# reference map for post-processing#10976
Draft
live1206 wants to merge 44 commits into
Draft
[Draft] Use hybrid C# reference map for post-processing#10976live1206 wants to merge 44 commits into
live1206 wants to merge 44 commits into
Conversation
commit: |
Contributor
|
No changes needing a change description found. |
This reverts commit ff55509.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
You can try these changes here
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a hybrid reference-map replacement for C# generated-code post-processing.
The hybrid path replaces broad Roslyn reference-map construction with:
No benchmark measurement/profiling code is included in the production generator path in this PR.
Why
The earlier experimental PR measured full generation and identified Roslyn reference-map construction inside
GeneratedCodeWorkspace.PostProcessAsync()as the largest hotspot.This PR keeps generated output parity with the Roslyn cleanup path while moving generated-code reachability to provider metadata.
Latest Benchmark Data
Latest data from benchmark PR #10885 after porting the current #10976 hybrid analyzer changes (including generated body invocation edges and base-preserved reachability).
Benchmark output root:
/tmp/typespec-final-hybrid-bench-20260624-0943.Full-generation BenchmarkDotNet, averaged across 3 local runs:
895.8 ms67.78 MB859.9 ms57.75 MBApproximate full-generation improvement:
Focused profile data, using 72 Roslyn-mode and 72 provider-mode invocations from the same runs (median):
357.2 ms23.70 MB263.2 ms17.83 MB0.79 ms0.06 MBApproximate focused reference-map improvement:
Profile notes:
POSTPROCESSING_BENCHMARK_PROFILE_STEPS=trueon the full-generation benchmark so both paths run against realTypeProvideroutput.PostProcessor.Internalize.BuildPublicReferenceMapAsyncandPostProcessor.Remove.BuildAllReferenceMapAsync.Generation.ProviderReferenceMapShadowAnalysis,PostProcessor.Internalize.UseShadowCandidates,PostProcessor.Internalize.UseShadowPublicizeCandidates,PostProcessor.Remove.UseShadowCandidates, andPostProcessor.Remove.BuildShadowReferencedSet..NET 10.0.9, Ubuntu 26.04, AMD EPYC 7763.Correctness Notes
The hybrid implementation preserves Roslyn cleanup behavior for generated output parity:
ChangeTrackingDictionaryandOptionalChangeTrackingListandChangeTrackingDictionary_typesToKeepbehaviorsrc/Generatedare not scanned; reachability is based on current providers/generated workspace plus custom/API roots, matching Roslyn's workspace inputsAzure SDK DPG Regen Note
Azure/azure-sdk-for-net#60128 completed a full DPG regen with no
sdk/**/api/**changes.The regen has a few extra generated
internalmodel/serialization files. This is expected: the hybrid provider map keeps conservative client body dependencies from service metadata to avoid broad Roslyn body-reference scans and preserve correctness for body-only generated references. These files are internal implementation details and do not affect public API.Validation
Local validation performed while stabilizing the PR included:
dotnet build packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Microsoft.TypeSpec.Generator.csproj -c Release1530/1530passedSample-TypeSpecSpector/http/authentication/api-keySpector/http/parameters/collection-formatSpector/http/documentationSpector/http/special-headers/repeatabilityImplemented Generated Dependency Handling
This PR now avoids Roslyn body scanning for several generated cases:
CollectionResultDefinitionClientProviderRestClientProviderCustom/shared code references still use Roslyn because arbitrary user C# can reference generated types in ways providers cannot reliably describe.
Follow-Up Performance Opportunities
Potential next improvements, ordered by reward/risk:
AddMatchingNameCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com