Skip to content

[python] Use specific exception types in status code range mock_api tests #10992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 2 commits into from
Jun 16, 2026
Merged

[python] Use specific exception types in status code range mock_api tests #10992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ec66e
[python] Use specific exception types in status code range mock_api t…
msyyc Jun 16, 2026
93720f0
Merge branch 'main' into fix-test-case-for-response-error
msyyc Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-test-case-for-response-error-2026-6-16-0-0-0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: internal
packages:
- "@typespec/http-client-python"
---

Use specific exception types in status code range mock_api tests for sync and async
8 changes: 2 additions & 6 deletions packages/http-client-python/generator/pygen/codegen/models/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ class NamespaceType(str, Enum):

LOCALS_LENGTH_LIMIT = 25

REQUEST_BUILDER_BODY_VARIABLES_LENGTH = (
6 # how many body variables are present in a request builder
)
REQUEST_BUILDER_BODY_VARIABLES_LENGTH = 6 # how many body variables are present in a request builder

OPERATION_BODY_VARIABLES_LENGTH = (
14 # how many body variables are present in an operation
)
OPERATION_BODY_VARIABLES_LENGTH = 14 # how many body variables are present in an operation
8 changes: 4 additions & 4 deletions ...p-client-python/tests/mock_api/shared/asynctests/test_response_status_code_range_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ async def client():


@pytest.mark.asyncio
async def test_error_response_status_code_in_range(client: StatusCodeRangeClient):
with pytest.raises(Exception) as exc_info:
async def test_error_response_status_code_in_range(client: StatusCodeRangeClient, core_library):
with pytest.raises(core_library.exceptions.HttpResponseError) as exc_info:
await client.error_response_status_code_in_range()

error = exc_info.value.model
Expand All @@ -28,8 +28,8 @@ async def test_error_response_status_code_in_range(client: StatusCodeRangeClient


@pytest.mark.asyncio
async def test_error_response_status_code_404(client: StatusCodeRangeClient):
with pytest.raises(Exception) as exc_info:
async def test_error_response_status_code_404(client: StatusCodeRangeClient, core_library):
with pytest.raises(core_library.exceptions.ResourceNotFoundError) as exc_info:
await client.error_response_status_code404()

error = exc_info.value.model
Expand Down
8 changes: 4 additions & 4 deletions packages/http-client-python/tests/mock_api/shared/test_response_status_code_range.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ def client():
yield client


def test_error_response_status_code_in_range(client: StatusCodeRangeClient):
with pytest.raises(Exception) as exc_info:
def test_error_response_status_code_in_range(client: StatusCodeRangeClient, core_library):
with pytest.raises(core_library.exceptions.HttpResponseError) as exc_info:
client.error_response_status_code_in_range()

error = exc_info.value.model
Expand All @@ -25,8 +25,8 @@ def test_error_response_status_code_in_range(client: StatusCodeRangeClient):
assert exc_info.value.response.status_code == 494


def test_error_response_status_code_404(client: StatusCodeRangeClient):
with pytest.raises(Exception) as exc_info:
def test_error_response_status_code_404(client: StatusCodeRangeClient, core_library):
with pytest.raises(core_library.exceptions.ResourceNotFoundError) as exc_info:
client.error_response_status_code404()

error = exc_info.value.model
Expand Down
Loading